Re: [ptxdist] [PATCH v2] lowpan-tools: update lowpan-patches

["Jürgen Beisert" <jbe@pengutronix.de>]

On Monday 06 January 2014 11:50:57 Michael Olbrich wrote:
> On Mon, Jan 06, 2014 at 09:25:08AM +0100, Alexander Aring wrote:
> > On Mon, Jan 06, 2014 at 08:40:24AM +0100, Jürgen Beisert wrote:
> > > On Monday 13 May 2013 17:00:36 Michael Olbrich wrote:
> > > > On Mon, May 13, 2013 at 02:38:10PM +0200, Alexander Aring wrote:
> > > > > Currently there is no way to make a new lowpan-tools release.
> > > > > This patch synchronize the patches from version 0.3 with current
> > > > > git master.
> > > > >
> > > > > Delete Patch 0001-Avoid-crashing-in-izcoordinator.patch. Which is
> > > > > replaced by upstream
> > > > > 0001-izoordinator-Fixes-to-error-handling.patch patch.
> > > >
> > > > Thanks, applied.
> > >
> > > This package fails in the prepare stage when the LOWPAN_TOOLS_TESTS is
> > > not set. The 'configure' script always checks for python.
> > >
> > > I do not know yet how this package depends on python: Should we always
> > > build python in order to make this package build again or should we add
> > > a new parameter to its configure.ac to switch off this test, when the
> > > test tools are disabled?
> >
> > indeed. The 'configure' script always checks for python and generate a
> > python 'site-package module'.
> >
> > The LOWPAN_TOOLS_TESTS needs this 'module' only. But at the moment there
> > is no 'enable/disable' switch in the 'configure' script.
> >
> > We shall change:
> >
> > "select PYTHON if LOWPAN_TOOLS_TESTS" to "select PYTHON"
> >
> > Thanks for the hint!
>
> That should not be necessary. PTXdist always needs the system python, so
> setting ac_cv_path_PYTHON=python should be enough to get
> <ptxdist>/bin/python. The result won't be anything usefull, but it should
> compile.

Yes, it does. The required change looks very simply now:

diff --git a/rules/lowpan-tools.make b/rules/lowpan-tools.make
index a4919bd..24e7568 100644
--- a/rules/lowpan-tools.make
+++ b/rules/lowpan-tools.make
@@ -35,7 +35,7 @@ LOWPAN_TOOLS_CONF_ENV = \
 ifdef PTXCONF_LOWPAN_TOOLS_TESTS
 LOWPAN_TOOLS_CONF_ENV += ac_cv_path_PYTHON=$(CROSS_PYTHON)
 else
-LOWPAN_TOOLS_CONF_ENV += ac_cv_path_PYTHON=:
+LOWPAN_TOOLS_CONF_ENV += ac_cv_path_PYTHON=python
 endif

 #

Tested-by: Juergen Beisert <jbe@pengutronix.de>

But: "select PYTHON" means Python is required at run-time. Using 
the "$(CROSS_PYTHON)" suggests Python is required only at build-time. Am I 
wrong?

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de