From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1W08i9-0007N9-BK for ptxdist@pengutronix.de; Mon, 06 Jan 2014 12:51:13 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1W08i9-0007q3-9e for ptxdist@pengutronix.de; Mon, 06 Jan 2014 12:51:13 +0100 Date: Mon, 6 Jan 2014 12:51:13 +0100 From: Michael Olbrich Message-ID: <20140106115113.GA25627@pengutronix.de> References: <1368448690-15034-1-git-send-email-alex.aring@gmail.com> <20140106082507.GA12646@omega> <20140106105057.GF2156@pengutronix.de> <201401061220.54164.jbe@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201401061220.54164.jbe@pengutronix.de> Subject: Re: [ptxdist] [PATCH v2] lowpan-tools: update lowpan-patches Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mon, Jan 06, 2014 at 12:20:54PM +0100, J=FCrgen Beisert wrote: > On Monday 06 January 2014 11:50:57 Michael Olbrich wrote: > > On Mon, Jan 06, 2014 at 09:25:08AM +0100, Alexander Aring wrote: > > > On Mon, Jan 06, 2014 at 08:40:24AM +0100, J=FCrgen Beisert wrote: > > > > On Monday 13 May 2013 17:00:36 Michael Olbrich wrote: > > > > > On Mon, May 13, 2013 at 02:38:10PM +0200, Alexander Aring wrote: > > > > > > Currently there is no way to make a new lowpan-tools release. > > > > > > This patch synchronize the patches from version 0.3 with current > > > > > > git master. > > > > > > > > > > > > Delete Patch 0001-Avoid-crashing-in-izcoordinator.patch. Which = is > > > > > > replaced by upstream > > > > > > 0001-izoordinator-Fixes-to-error-handling.patch patch. > > > > > > > > > > Thanks, applied. > > > > > > > > This package fails in the prepare stage when the LOWPAN_TOOLS_TESTS= is > > > > not set. The 'configure' script always checks for python. > > > > > > > > I do not know yet how this package depends on python: Should we alw= ays > > > > build python in order to make this package build again or should we= add > > > > a new parameter to its configure.ac to switch off this test, when t= he > > > > test tools are disabled? > > > > > > indeed. The 'configure' script always checks for python and generate a > > > python 'site-package module'. > > > > > > The LOWPAN_TOOLS_TESTS needs this 'module' only. But at the moment th= ere > > > is no 'enable/disable' switch in the 'configure' script. > > > > > > We shall change: > > > > > > "select PYTHON if LOWPAN_TOOLS_TESTS" to "select PYTHON" > > > > > > Thanks for the hint! > > > > That should not be necessary. PTXdist always needs the system python, so > > setting ac_cv_path_PYTHON=3Dpython should be enough to get > > /bin/python. The result won't be anything usefull, but it shou= ld > > compile. > = > Yes, it does. The required change looks very simply now: > = > diff --git a/rules/lowpan-tools.make b/rules/lowpan-tools.make > index a4919bd..24e7568 100644 > --- a/rules/lowpan-tools.make > +++ b/rules/lowpan-tools.make > @@ -35,7 +35,7 @@ LOWPAN_TOOLS_CONF_ENV =3D \ > ifdef PTXCONF_LOWPAN_TOOLS_TESTS > LOWPAN_TOOLS_CONF_ENV +=3D ac_cv_path_PYTHON=3D$(CROSS_PYTHON) > else > -LOWPAN_TOOLS_CONF_ENV +=3D ac_cv_path_PYTHON=3D: > +LOWPAN_TOOLS_CONF_ENV +=3D ac_cv_path_PYTHON=3Dpython > endif > = > # > = > Tested-by: Juergen Beisert good. > But: "select PYTHON" means Python is required at run-time. Using = > the "$(CROSS_PYTHON)" suggests Python is required only at build-time. Am = I = > wrong? "select PYTHON" means Python is required at run-time _and_ at build-time. We need it at run-time to run the python scripts and CROSS_PYTHON during build time. CROSS_PYTHON is HOST_PYTHON and some cross magic, so select HOST_PYTHON if BUILDTIME select PYTHON if RUNTIME might work, but imho that's not worth the trouble. mol -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de