[ptxdist] Patch proposal: Midnight Commander depends on readline

[ptxdist] Patch proposal: Midnight Commander depends on readline

[Felix Mellmann]

Midnight Commander fails to build without libreadline, so I'd like to
propose a patch which selects READLINE as dependency to Midnight Commander.

Regards,
Felix

diff -urdN ptxdist-2013.12.0/rules/mc.in ptxdist-2013.12.0.debugged/rules/mc.in
--- ptxdist-2013.12.0/rules/mc.in       2013-12-18 10:48:42.000000000 +0100
+++ ptxdist-2013.12.0.debugged/rules/mc.in      2013-12-26
20:33:46.864727736 +0100
@@ -3,6 +3,7 @@
 menuconfig MC
        tristate
        select GLIB
+       select READLINE
        select NCURSES if MC_USES_NCURSES
        select SLANG if MC_USES_SLANG
        select LIBC_NSL



-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Patch proposal: Midnight Commander depends on readline

[Jürgen Beisert]

Hi Felix,

On Thursday 26 December 2013 20:35:40 Felix Mellmann wrote:
> Midnight Commander fails to build without libreadline, so I'd like to
> propose a patch which selects READLINE as dependency to Midnight Commander.
>
> diff -urdN ptxdist-2013.12.0/rules/mc.in
> ptxdist-2013.12.0.debugged/rules/mc.in --- ptxdist-2013.12.0/rules/mc.in   
>    2013-12-18 10:48:42.000000000 +0100 +++
> ptxdist-2013.12.0.debugged/rules/mc.in      2013-12-26
> 20:33:46.864727736 +0100
> @@ -3,6 +3,7 @@
>  menuconfig MC
>         tristate
>         select GLIB
> +       select READLINE
>         select NCURSES if MC_USES_NCURSES
>         select SLANG if MC_USES_SLANG
>         select LIBC_NSL

Hmm, I tried it here with READLINE disabled and without your change:

 - with MC's "Kind of MMI  (no preference)": it builds successfully.
 - with MC's "Kind of MMI  (Use ncurses  )": it builds successfully.
 - with MC's "Kind of MMI  (Use slang    )": it builds successfully.

So, no idea what the cause of your build failure is.

Hint: I tried with "ptxdist clean; ptxdist targetinstall mc".

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Patch proposal: Midnight Commander depends on readline

[Felix Mellmann]

Jürgen Beisert <jbe@...> writes:

> 
> 
> Hmm, I tried it here with READLINE disabled and without your change:
> 
>  - with MC's "Kind of MMI  (no preference)": it builds successfully.
>  - with MC's "Kind of MMI  (Use ncurses  )": it builds successfully.
>  - with MC's "Kind of MMI  (Use slang    )": it builds successfully.
> 
> So, no idea what the cause of your build failure is.
> 
> Hint: I tried with "ptxdist clean; ptxdist targetinstall mc".
> 
> jbe
> 


Well, actually I cannot reproduce the error anymore. But once I had linking
errors complaining about functions exported by readline, but this does not
happen anymore. Ok, then please drop my proposal.

Regards,
Felix



-- 
ptxdist mailing list
ptxdist@pengutronix.de