mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] Why was shadow support disabled for sudo?
@ 2013-11-30 14:13 Felix Mellmann
  2013-11-30 14:45 ` Marc Kleine-Budde
  0 siblings, 1 reply; 7+ messages in thread
From: Felix Mellmann @ 2013-11-30 14:13 UTC (permalink / raw)
  To: ptxdist

Hello,

as I'm trying to adopt PTX to an i.MX53 based board, I wondered why sudo 
didn't accept any user passwords. sudo.make calls configure with --disable-
shadow. Removing this line enables sudo to retrieve passwords from 
/etc/shadow and everything is fine.
Is there a reason, why shadow support was disabled?

I am using PTXdist 2013.09.0.

Thank you for your help!

Felix


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ptxdist] Why was shadow support disabled for sudo?
  2013-11-30 14:13 [ptxdist] Why was shadow support disabled for sudo? Felix Mellmann
@ 2013-11-30 14:45 ` Marc Kleine-Budde
  2013-11-30 15:26   ` Felix Mellmann
  0 siblings, 1 reply; 7+ messages in thread
From: Marc Kleine-Budde @ 2013-11-30 14:45 UTC (permalink / raw)
  To: ptxdist; +Cc: Felix Mellmann


[-- Attachment #1.1: Type: text/plain, Size: 756 bytes --]

On 11/30/2013 03:13 PM, Felix Mellmann wrote:
> Hello,
> 
> as I'm trying to adopt PTX to an i.MX53 based board, I wondered why sudo 
> didn't accept any user passwords. sudo.make calls configure with --disable-
> shadow. Removing this line enables sudo to retrieve passwords from 
> /etc/shadow and everything is fine.
> Is there a reason, why shadow support was disabled?
> 
> I am using PTXdist 2013.09.0.

It's probably a bug, please send a patch.

cheers,
Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ptxdist] Why was shadow support disabled for sudo?
  2013-11-30 14:45 ` Marc Kleine-Budde
@ 2013-11-30 15:26   ` Felix Mellmann
  2013-11-30 16:03     ` Marc Kleine-Budde
  2013-12-03 10:10     ` Marc Kleine-Budde
  0 siblings, 2 replies; 7+ messages in thread
From: Felix Mellmann @ 2013-11-30 15:26 UTC (permalink / raw)
  To: ptxdist

Marc Kleine-Budde <mkl@...> writes:

> 
> It's probably a bug, please send a patch.
> 
> cheers,
> Marc

I was just wondering, if there is still a reason to disable shadow support. 
Obviously it was at some time intended ...
Without shadow support sudo does not accept any password stored in 
/etc/shadow (as usual).

Regards,
Felix

diff -urdN ptxdist-2013.09.0.orig/rules/sudo.make ptxdist-
2013.09.0/rules/sudo.make
--- ptxdist-2013.09.0.orig/rules/sudo.make	2013-09-09 15:59:23.000000000 
+0200
+++ ptxdist-2013.09.0/rules/sudo.make	2013-11-30 16:23:42.320182693 +0100
@@ -44,7 +44,6 @@
 #
 SUDO_AUTOCONF = \
 	$(CROSS_AUTOCONF_USR) \
-	--disable-shadow \
 	--enable-root-sudo \
 	--disable-log-host \
 	--enable-noargs-shell \



-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ptxdist] Why was shadow support disabled for sudo?
  2013-11-30 15:26   ` Felix Mellmann
@ 2013-11-30 16:03     ` Marc Kleine-Budde
  2013-11-30 16:34       ` Felix Mellmann
  2013-11-30 19:16       ` Robert Schwebel
  2013-12-03 10:10     ` Marc Kleine-Budde
  1 sibling, 2 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2013-11-30 16:03 UTC (permalink / raw)
  To: ptxdist; +Cc: Felix Mellmann


[-- Attachment #1.1: Type: text/plain, Size: 786 bytes --]

On 11/30/2013 04:26 PM, Felix Mellmann wrote:
> Marc Kleine-Budde <mkl@...> writes:
> 
>>
>> It's probably a bug, please send a patch.
>>
>> cheers,
>> Marc
> 
> I was just wondering, if there is still a reason to disable shadow support. 
> Obviously it was at some time intended ...

No, not really I think. It was added by Robert back in 2008.

> Without shadow support sudo does not accept any password stored in 
> /etc/shadow (as usual).

Thanks, can we add your Signed-off-by?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ptxdist] Why was shadow support disabled for sudo?
  2013-11-30 16:03     ` Marc Kleine-Budde
@ 2013-11-30 16:34       ` Felix Mellmann
  2013-11-30 19:16       ` Robert Schwebel
  1 sibling, 0 replies; 7+ messages in thread
From: Felix Mellmann @ 2013-11-30 16:34 UTC (permalink / raw)
  To: ptxdist

Marc Kleine-Budde <mkl@...> writes:

> 
> Thanks, can we add your Signed-off-by?
> 
> Marc
> 

Yes, please.

Felix




-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ptxdist] Why was shadow support disabled for sudo?
  2013-11-30 16:03     ` Marc Kleine-Budde
  2013-11-30 16:34       ` Felix Mellmann
@ 2013-11-30 19:16       ` Robert Schwebel
  1 sibling, 0 replies; 7+ messages in thread
From: Robert Schwebel @ 2013-11-30 19:16 UTC (permalink / raw)
  To: ptxdist; +Cc: Felix Mellmann


[-- Attachment #1.1: Type: text/plain, Size: 807 bytes --]

On Sat, Nov 30, 2013 at 05:03:05PM +0100, Marc Kleine-Budde wrote:
> On 11/30/2013 04:26 PM, Felix Mellmann wrote:
> > Marc Kleine-Budde <mkl@...> writes:
> > 
> >>
> >> It's probably a bug, please send a patch.
> >>
> >> cheers,
> >> Marc
> > 
> > I was just wondering, if there is still a reason to disable shadow support. 
> > Obviously it was at some time intended ...
> 
> No, not really I think. It was added by Robert back in 2008.

I can't remember why it was added.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [ptxdist] Why was shadow support disabled for sudo?
  2013-11-30 15:26   ` Felix Mellmann
  2013-11-30 16:03     ` Marc Kleine-Budde
@ 2013-12-03 10:10     ` Marc Kleine-Budde
  1 sibling, 0 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2013-12-03 10:10 UTC (permalink / raw)
  To: ptxdist; +Cc: Felix Mellmann


[-- Attachment #1.1: Type: text/plain, Size: 1205 bytes --]

On 11/30/2013 04:26 PM, Felix Mellmann wrote:
> Marc Kleine-Budde <mkl@...> writes:
> 
>>
>> It's probably a bug, please send a patch.
>>
>> cheers,
>> Marc
> 
> I was just wondering, if there is still a reason to disable shadow support. 
> Obviously it was at some time intended ...
> Without shadow support sudo does not accept any password stored in 
> /etc/shadow (as usual).
> 
> Regards,
> Felix
> 
> diff -urdN ptxdist-2013.09.0.orig/rules/sudo.make ptxdist-
> 2013.09.0/rules/sudo.make
> --- ptxdist-2013.09.0.orig/rules/sudo.make	2013-09-09 15:59:23.000000000 
> +0200
> +++ ptxdist-2013.09.0/rules/sudo.make	2013-11-30 16:23:42.320182693 +0100
> @@ -44,7 +44,6 @@
>  #
>  SUDO_AUTOCONF = \
>  	$(CROSS_AUTOCONF_USR) \
> -	--disable-shadow \
>  	--enable-root-sudo \
>  	--disable-log-host \
>  	--enable-noargs-shell \

Applied to master, with an explicit --enable-shadow

tnx,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-12-03 10:10 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-30 14:13 [ptxdist] Why was shadow support disabled for sudo? Felix Mellmann
2013-11-30 14:45 ` Marc Kleine-Budde
2013-11-30 15:26   ` Felix Mellmann
2013-11-30 16:03     ` Marc Kleine-Budde
2013-11-30 16:34       ` Felix Mellmann
2013-11-30 19:16       ` Robert Schwebel
2013-12-03 10:10     ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox