From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1VK32n-0001Mv-ST for ptxdist@pengutronix.de; Thu, 12 Sep 2013 11:18:33 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1VK32n-0000nz-Qr for ptxdist@pengutronix.de; Thu, 12 Sep 2013 11:18:33 +0200 Date: Thu, 12 Sep 2013 11:18:33 +0200 From: Michael Olbrich Message-ID: <20130912091833.GA18526@pengutronix.de> References: <1378904354-23820-1-git-send-email-post@lespocky.de> <20130911130910.GE24802@pengutronix.de> <579b6e958fe0b6191ad4087bdd6e68f1@idefix.lespocky.dyndns.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <579b6e958fe0b6191ad4087bdd6e68f1@idefix.lespocky.dyndns.org> Subject: Re: [ptxdist] [PATCH 1/2] net-snmp: improve help texts and defaults Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hi, On Wed, Sep 11, 2013 at 03:26:28PM +0200, Alexander Dahl wrote: > Am 2013-09-11 15:09, schrieb Uwe Kleine-K=F6nig: > >> - --disable-mib-config-checking \ > >> - --disable-mfd-rewrites \ > >> + --enable-mib-config-checking \ > >> + --enable-mfd-rewrites \ > = > > Is this change intended? This is neither a change of help texts nor of > > defaults. So it's not documented in the change log, right? = > = > Yes, intended and I would call this changing defaults. Maybe I should > have made two patches, this was the first idea. > = > > What are the > > effects? I didn't recheck your previous mails, but wasn't one of these > > the option that you called bleeding edge? > = > Sort of. = > = > --enable-mib-config-checking is just what it claims, the option for > additional MIB modules compiled (second patch) are checked against > conflicts, doubles and the like. Without setting this option it would > just produce a warning, with this option the build fails. For example > this would be the case if someone selects the "agentx" module with the > dedicated option and also adds it to the new without-this-mib-module > option. Disabling this check would result in silently not building the > module. This is why I would prefer to set this option. Add a short comment to the commit message. > --enable-mfd-rewrites is the "bleeding edge" one I mentioned in the > other mail. Basically what I understood the upstream guys do is > rewriting some MIB modules. Disabling this options means using the old > or even ancient not rewritten module while enabling means using the new > rewritten module. This affects MIBs like the IF-MIB which are kind of > basic. Because they also claim this is a LTS branch, I would consider it > safe to set this, but this is open to discussion. However > (re)introducing this as another option to the in rule would be fine for > me as well, but the net-snmp options are already a lot so I thought it > would be enough to set a reasonable default in net-snmp.make. Make this a separate patch and add this to the commit message. Unless someone else disagrees, changing the default is ok for me. A separate patch will make it easier to find if there are any problems with it. Michael -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de