From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1VJTYd-0005Jm-AX for ptxdist@pengutronix.de; Tue, 10 Sep 2013 21:25:03 +0200 Received: from ukl by dude.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1VJTYd-0002ty-9K for ptxdist@pengutronix.de; Tue, 10 Sep 2013 21:25:03 +0200 Date: Tue, 10 Sep 2013 21:25:03 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20130910192503.GD24802@pengutronix.de> References: <1378240187-21469-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH 1/2] net-snmp: drop usage of undefined Kconfig variables Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hallo Alex, On Tue, Sep 10, 2013 at 04:31:44PM +0200, Alexander Dahl wrote: > although this is already in master, I had a look in this (after > wondering why I could not get some values from IF-MIB). > = > Am 2013-09-03 22:29, schrieb Uwe Kleine-K=F6nig: > > Some variables that are used in the .make file with ifdef are not defin= ed > > in the .in file. So all ifdefs evaluate to false. Hard-code this behavi= our > > instead. > = > I see some problems with the hard coded options. I'll explain one by > one: > > --enable-shared \ > > --disable-embedded-perl \ > > --without-perl-modules \ > > - --disable-static > > + --disable-static \ > > + --disable-privacy \ > > + --disable-internal-md5 \ > = > Agreed. > = > > + --disable-agentx-dom-sock-only \ > = > Handled later. > = > > + --disable-mib-config-checking \ > = > Bad for the upcoming mib module handling. I'd like to see this enabled. > = > > + --disable-mfd-rewrites \ > = > This is a very conservative setting. However --enable-mfd-rewrites is > rather bleeding edge. Unfortunately as far as I can see, the good ideas > mentioned on http://www.net-snmp.org/wiki/index.php/MIB_Module_ReWrites > are not implemented in 5.7 so maybe we drop this and let net-snmp find a > sane setting for each affected MIB instead of setting this globally. > = > > + --disable-testing-code \ > = > Agreed. > = > > + --disable-reentrant \ > = > Maybe make it configurable again? You seem to assume this was configurable before but that is wrong. There was something like if PTXCONF_... --enable-reentrant else --disable-reentrant endif but the variable in the if condition wasn't defined. So it didn't look like being hardcoded to --disable-reentrant but effectively it was. So this patch is noop and if you see a problem with the options I hardcode now then the problem was already there before because you couldn't change the respective variable without adding it first to net-snmp.in. = > > + --disable-embedded-perl \ > > + --disable-ucd-snmp-compatibility > = > Agreed. > = > Did you have a look at `configure --help` of a recent net-snmp 5.6.x or > 5.7.x? No, I just dropped all ifs depending on non-existant Kconfig vars. Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- = ptxdist mailing list ptxdist@pengutronix.de