Re: [ptxdist] [PATCH 1/2] net-snmp: drop usage of undefined Kconfig variables

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hallo Alex,

On Tue, Sep 10, 2013 at 04:31:44PM +0200, Alexander Dahl wrote:
> although this is already in master, I had a look in this (after
> wondering why I could not get some values from IF-MIB).
> 
> Am 2013-09-03 22:29, schrieb Uwe Kleine-König:
> > Some variables that are used in the .make file with ifdef are not defined
> > in the .in file. So all ifdefs evaluate to false. Hard-code this behaviour
> > instead.
> 
> I see some problems with the hard coded options. I'll explain one by
> one:
> >  	--enable-shared \
> >  	--disable-embedded-perl \
> >  	--without-perl-modules \
> > -	--disable-static
> > +	--disable-static \
> > +	--disable-privacy \
> > +	--disable-internal-md5 \
> 
> Agreed.
> 
> > +	--disable-agentx-dom-sock-only \
> 
> Handled later.
> 
> > +	--disable-mib-config-checking \
> 
> Bad for the upcoming mib module handling. I'd like to see this enabled.
> 
> > +	--disable-mfd-rewrites \
> 
> This is a very conservative setting. However --enable-mfd-rewrites is
> rather bleeding edge. Unfortunately as far as I can see, the good ideas
> mentioned on http://www.net-snmp.org/wiki/index.php/MIB_Module_ReWrites
> are not implemented in 5.7 so maybe we drop this and let net-snmp find a
> sane setting for each affected MIB instead of setting this globally.
> 
> > +	--disable-testing-code \
> 
> Agreed.
> 
> > +	--disable-reentrant \
> 
> Maybe make it configurable again?
You seem to assume this was configurable before but that is wrong. There
was something like

	if PTXCONF_...
		--enable-reentrant
	else
		--disable-reentrant
	endif

but the variable in the if condition wasn't defined. So it didn't look
like being hardcoded to --disable-reentrant but effectively it was.

So this patch is noop and if you see a problem with the options I
hardcode now then the problem was already there before because you
couldn't change the respective variable without adding it first to
net-snmp.in.
 
> > +	--disable-embedded-perl \
> > +	--disable-ucd-snmp-compatibility
> 
> Agreed.
> 
> Did you have a look at `configure --help` of a recent net-snmp 5.6.x or
> 5.7.x?
No, I just dropped all ifs depending on non-existant Kconfig vars.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de