From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1VJ2it-0007Vi-UT for ptxdist@pengutronix.de; Mon, 09 Sep 2013 16:45:51 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1VJ2it-0000GB-Sp for ptxdist@pengutronix.de; Mon, 09 Sep 2013 16:45:51 +0200 Date: Mon, 9 Sep 2013 16:45:51 +0200 From: Michael Olbrich Message-ID: <20130909144551.GA26086@pengutronix.de> References: <1378388934-7790-1-git-send-email-post@lespocky.de> <20130909094951.GF31967@pengutronix.de> <3406c8c7a7f86889725df181f01f999a@idefix.lespocky.dyndns.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3406c8c7a7f86889725df181f01f999a@idefix.lespocky.dyndns.org> Subject: Re: [ptxdist] [PATCH] [lldpd] add package Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hi, please change the subject to "lldpd: ..." On Mon, Sep 09, 2013 at 12:43:09PM +0200, Alexander Dahl wrote: > Am 2013-09-09 11:49, schrieb Michael Olbrich: > > This fail to compile here: > > [...] > > checking for snmp_register_callback in -lnetsnmp... yes > > checking for netsnmp_enable_subagent... no > > configure: error: *** no subagent support in net-snmp > > make: *** [..../state/lldpd.prepare] Error 1 > > [...] > > > > Any idea what might go wrong here? > > Yes. This is tricky and didn't have a good idea how to check it. There's > the parameter NET_SNMP_MIB_MODULES which is used in this parameter in > the prepare stage: > > --with-mib-modules=$(PTXCONF_NET_SNMP_MIB_MODULES) > > You have to add/include "agentx" in the ptxdist menuconfig entry > NET_SNMP_MIB_MODULES. You can add other and there's no simple switch for > each of them. This is the way to enable several things in net-snmp and > lldpd seems to check it the right way, but I had no idea how to > "translate" this mechanism to the ptxdist layer above. Make an option for "agentx", so you can select it. > >> +if LLDPD > >> + > >> +config LLDPD_PRIVSEP_USER > >> + string > >> + prompt "Which user to use for privilege separation" > >> + default "_lldpd" > > > > this seems to be a strange user. Why with '_'? > > This is the default lldpd uses. See the output of ./configure from > lldpd: > > --with-privsep-user Which user to use for privilege separation > [default=_lldpd] > --with-privsep-group Which group to use for privilege separation > [default=_lldpd] > --with-privsep-chroot Which directory to use to chroot lldpd > [default=/var/run/lldpd] > > Actually I set this user to nobody and the group to daemon. As far as I > understood lldpd this is hardcoded and I wanted to have it configurable > so I added it to the ptxdist menu and copied the defaults from lldpd. > Maybe the do not make sense for most of the users. Do you have a better > suggestion for this user and group? use "nobody" by default. Otherwise the defaults break targetinstall > >> +config LLDPD_OLDIES > >> + bool > >> + prompt "Enable compatibility with Linux kernel older than 2.6.18" > >> + default n > > > > no "default n" needed. Thats the default anyways. > > Good to know, but for me the code of the in rule is more clear if I add > this. However, if you want to have it removed, I'll remove it. thanks. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de