Re: [ptxdist] [PATCH] [lldpd] add package

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

please change the subject to "lldpd: ..."

On Mon, Sep 09, 2013 at 12:43:09PM +0200, Alexander Dahl wrote:
> Am 2013-09-09 11:49, schrieb Michael Olbrich:
> > This fail to compile here:
> > [...]
> > checking for snmp_register_callback in -lnetsnmp... yes
> > checking for netsnmp_enable_subagent... no
> > configure: error: *** no subagent support in net-snmp
> > make: *** [..../state/lldpd.prepare] Error 1
> > [...]
> > 
> > Any idea what might go wrong here?
> 
> Yes. This is tricky and didn't have a good idea how to check it. There's
> the parameter NET_SNMP_MIB_MODULES which is used in this parameter in
> the prepare stage:
> 
>   --with-mib-modules=$(PTXCONF_NET_SNMP_MIB_MODULES)
> 
> You have to add/include "agentx" in the ptxdist menuconfig entry
> NET_SNMP_MIB_MODULES. You can add other and there's no simple switch for
> each of them. This is the way to enable several things in net-snmp and
> lldpd seems to check it the right way, but I had no idea how to
> "translate" this mechanism to the ptxdist layer above.

Make an option for "agentx", so you can select it.

> >> +if LLDPD
> >> +
> >> +config LLDPD_PRIVSEP_USER
> >> +	string
> >> +	prompt "Which user to use for privilege separation"
> >> +	default "_lldpd"
> > 
> > this seems to be a strange user. Why with '_'?
> 
> This is the default lldpd uses. See the output of ./configure from
> lldpd:
> 
>   --with-privsep-user     Which user to use for privilege separation
>                           [default=_lldpd]
>   --with-privsep-group    Which group to use for privilege separation
>                           [default=_lldpd]
>   --with-privsep-chroot   Which directory to use to chroot lldpd
>                           [default=/var/run/lldpd]
> 
> Actually I set this user to nobody and the group to daemon. As far as I
> understood lldpd this is hardcoded and I wanted to have it configurable
> so I added it to the ptxdist menu and copied the defaults from lldpd.
> Maybe the do not make sense for most of the users. Do you have a better
> suggestion for this user and group?

use "nobody" by default. Otherwise the defaults break targetinstall

> >> +config LLDPD_OLDIES
> >> +	bool
> >> +	prompt "Enable compatibility with Linux kernel older than 2.6.18"
> >> +	default n
> > 
> > no "default n" needed. Thats the default anyways.
> 
> Good to know, but for me the code of the in rule is more clear if I add
> this. However, if you want to have it removed, I'll remove it.

thanks.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de