Re: [ptxdist] [PATCH] libcoap: add libcoap package

[Alexander Aring <alex.aring@gmail.com>]

Hi Marc,

On Thu, Aug 15, 2013 at 10:16:43AM +0200, Marc Kleine-Budde wrote:
> On 08/15/2013 08:25 AM, Alexander Aring wrote:
> [...]
> 
> >> Argh, autoconf without automake. Not your fault
> >>
> >> ...
> >>
> >> What about creating a proper automake'd version of libcoap?
> >>
> > Now I create a autotools project and see some very very bad things in
> > the libcoap. I need to screw up the complete buildsystem.
> > 
> > For exmaple, they have a config.h:
> 
> The config.h is autogenerated by autotools.
> 
Yea, I saw this too. AC_CONFIG_HEADERS([config.h]).

But the main "coap.h" header file for the api includes this "config.h" header
file. So a aplication which uses autotools can't do a include <coap.h>
because it includes the config.h from the autotools generated header file
and redefined all autotools related things.

Difficult to explain... :)

> > ...
> > #define PACKAGE_BUGREPORT ""
> > 
> > #define PACKAGE_NAME "libcoap"
> > ...
> > 
> > I need to drop the config.h because there stands some defines which is
> > setted manually, but normally setted by autoconf with AC_INIT like PACKAGE_NAME.
> > 
> > With this behaviour you get many redefined ... warnings from compiler if
> > you use the libcoap in a autotools buildsystem project.
> > 
> > There are several small things like this.
> > I need to say, I really don't understand this. They use autoconf but
> > setted defines manually so autoconf doesn't matter...
> > 
> > 
> > I need to rework this, so please don't add this to ptxdist right now.
> > 
> > And yes I will try to insert autoconf/automake into this project.
> 
> Fine. You can call me if you need help. If you need a template I suggest
> to use libabc.
> 
Ok thanks.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de