From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Thu, 15 Aug 2013 08:25:51 +0200 From: Alexander Aring Message-ID: <20130815062549.GA4070@x61s.8.8.8.8> References: <1375432732-12559-1-git-send-email-alex.aring@gmail.com> <52091518.1010108@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52091518.1010108@pengutronix.de> Subject: Re: [ptxdist] [PATCH] libcoap: add libcoap package Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: Marc Kleine-Budde Cc: ptxdist@pengutronix.de Hi Marc, On Mon, Aug 12, 2013 at 07:02:16PM +0200, Marc Kleine-Budde wrote: > On 08/02/2013 10:38 AM, Alexander Aring wrote: > > Signed-off-by: Alexander Aring > > --- > > ...ap-enable-shared-lib-and-install-examples.patch | 109 +++++++++++++++++++++ > > patches/libcoap-4.0.1/series | 1 + > > rules/libcoap.in | 10 ++ > > rules/libcoap.make | 61 ++++++++++++ > > 4 files changed, 181 insertions(+) > > create mode 100644 patches/libcoap-4.0.1/0001-libcoap-enable-shared-lib-and-install-examples.patch > > create mode 100644 patches/libcoap-4.0.1/series > > create mode 100644 rules/libcoap.in > > create mode 100644 rules/libcoap.make > > > > diff --git a/patches/libcoap-4.0.1/0001-libcoap-enable-shared-lib-and-install-examples.patch b/patches/libcoap-4.0.1/0001-libcoap-enable-shared-lib-and-install-examples.patch > > new file mode 100644 > > index 0000000..71c36c8 > > --- /dev/null > > +++ b/patches/libcoap-4.0.1/0001-libcoap-enable-shared-lib-and-install-examples.patch > > @@ -0,0 +1,109 @@ > > +From fe64f998eeb5d2a693400188b275007ce263fc87 Mon Sep 17 00:00:00 2001 > > +From: unknown author > > Who created the patch in the first place? > Uhm, I create the patch with quilt at first. Then I run a ptxdist --git extract to get the patch. So it seems I create this patch in a wrong way. I will check this in the next try, thanks. And it was me who create this patch. :-) > > +Date: Fri, 2 Aug 2013 10:25:26 +0200 > > +Subject: [PATCH] libcoap: enable shared lib and install examples > > + > > +Normally the buildsystem generates a static library. > > +This patch let generate the buildsystem a shared library and add > > +a install rule to the Makefile so we can install it on the system. > > + > > +Add also install rule for the examples and linking to the shared library. > > + > > +Signed-off-by: Alexander Aring > > +--- > > + Makefile.in | 21 +++++++++++++++++---- > > + examples/Makefile.in | 7 ++++++- > > + 2 files changed, 23 insertions(+), 5 deletions(-) > > + > > +diff --git a/Makefile.in b/Makefile.in > > +index 0ded496..21564aa 100644 > > +--- a/Makefile.in > > ++++ b/Makefile.in > > Argh, autoconf without automake. Not your fault > > ... > > What about creating a proper automake'd version of libcoap? > Now I create a autotools project and see some very very bad things in the libcoap. I need to screw up the complete buildsystem. For exmaple, they have a config.h: ... #define PACKAGE_BUGREPORT "" #define PACKAGE_NAME "libcoap" ... I need to drop the config.h because there stands some defines which is setted manually, but normally setted by autoconf with AC_INIT like PACKAGE_NAME. With this behaviour you get many redefined ... warnings from compiler if you use the libcoap in a autotools buildsystem project. There are several small things like this. I need to say, I really don't understand this. They use autoconf but setted defines manually so autoconf doesn't matter... I need to rework this, so please don't add this to ptxdist right now. And yes I will try to insert autoconf/automake into this project. Regards Alex -- ptxdist mailing list ptxdist@pengutronix.de