From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1UMwsp-0001es-Q2
	for ptxdist@pengutronix.de; Tue, 02 Apr 2013 10:47:59 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1UMwsn-0003ko-NK
	for ptxdist@pengutronix.de; Tue, 02 Apr 2013 10:47:57 +0200
Date: Tue, 2 Apr 2013 10:47:57 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20130402084757.GA28829@pengutronix.de>
References: <20130331191128.GA27525@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20130331191128.GA27525@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v2] glew: link against libX11
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sun, Mar 31, 2013 at 09:11:28PM +0200, Robert Schwebel wrote:
> src/visualinfo.c and src/glewinfo.c call XDestroyWindow, so we need to link against libX11.
> Otherwhise this breaks down with
> 
> /opt/OSELAS.Toolchain-2012.12.0/arm-1136jfs-linux-gnueabi/gcc-4.7.2-glibc-2.16.0-binutils-2.22-kernel-3.6-sanitized/bin/../lib/gcc/arm-1136jfs-linux-gnueabi/4.7.2/../../../../arm-1136jfs-linux-gnueabi/bin/ld: src/glewinfo.o: undefined reference to symbol 'XDestroyWindow'

Hmm, I'm not seeing it. The problem is definitely there, and it will fail
with a newer toolchain, but with a different error.

> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
> Changes in v2:
> - get -lX11 via pkg-config (reported by Alexander Aring <alex.aring@gmail.com>)
> 
>  rules/glew.make |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/glew.make b/rules/glew.make
> index 08acaff..955cbdd 100644
> --- a/rules/glew.make
> +++ b/rules/glew.make
> @@ -41,7 +41,7 @@ GLEW_MAKE_OPT	:= \
>  	LD=$(CROSS_CC) \
>  	CFLAGS.EXTRA='$(CROSS_CPPFLAGS) $(CROSS_CFLAGS)' \
>  	LDFLAGS.EXTRA='$(CROSS_LDFLAGS)' \
> -	LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu`' \
> +	LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu x11`' \

This is wrong. libX11 is only needed by the tools not libglew itself. We
should not build the tools and drop the dependency for libX11 instead.

Michael

>  	GLEW_DEST=$(GLEW_PKGDIR)/usr \
>  	LIBDIR=$(GLEW_PKGDIR)/usr/lib \
>  	M_ARCH=$(PTXCONF_ARCH_STRING)
> -- 
> 1.7.10.4
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de