From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] glew: link against libX11
Date: Tue, 2 Apr 2013 10:47:57 +0200 [thread overview]
Message-ID: <20130402084757.GA28829@pengutronix.de> (raw)
In-Reply-To: <20130331191128.GA27525@pengutronix.de>
On Sun, Mar 31, 2013 at 09:11:28PM +0200, Robert Schwebel wrote:
> src/visualinfo.c and src/glewinfo.c call XDestroyWindow, so we need to link against libX11.
> Otherwhise this breaks down with
>
> /opt/OSELAS.Toolchain-2012.12.0/arm-1136jfs-linux-gnueabi/gcc-4.7.2-glibc-2.16.0-binutils-2.22-kernel-3.6-sanitized/bin/../lib/gcc/arm-1136jfs-linux-gnueabi/4.7.2/../../../../arm-1136jfs-linux-gnueabi/bin/ld: src/glewinfo.o: undefined reference to symbol 'XDestroyWindow'
Hmm, I'm not seeing it. The problem is definitely there, and it will fail
with a newer toolchain, but with a different error.
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
> Changes in v2:
> - get -lX11 via pkg-config (reported by Alexander Aring <alex.aring@gmail.com>)
>
> rules/glew.make | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules/glew.make b/rules/glew.make
> index 08acaff..955cbdd 100644
> --- a/rules/glew.make
> +++ b/rules/glew.make
> @@ -41,7 +41,7 @@ GLEW_MAKE_OPT := \
> LD=$(CROSS_CC) \
> CFLAGS.EXTRA='$(CROSS_CPPFLAGS) $(CROSS_CFLAGS)' \
> LDFLAGS.EXTRA='$(CROSS_LDFLAGS)' \
> - LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu`' \
> + LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu x11`' \
This is wrong. libX11 is only needed by the tools not libglew itself. We
should not build the tools and drop the dependency for libX11 instead.
Michael
> GLEW_DEST=$(GLEW_PKGDIR)/usr \
> LIBDIR=$(GLEW_PKGDIR)/usr/lib \
> M_ARCH=$(PTXCONF_ARCH_STRING)
> --
> 1.7.10.4
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2013-04-02 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 19:11 Robert Schwebel
2013-04-02 8:47 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402084757.GA28829@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox