From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1ULBZt-0002zH-95 for ptxdist@pengutronix.de; Thu, 28 Mar 2013 13:05:09 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1ULBZr-0001kj-60 for ptxdist@pengutronix.de; Thu, 28 Mar 2013 13:05:07 +0100 Date: Thu, 28 Mar 2013 13:05:07 +0100 From: Michael Olbrich Message-ID: <20130328120507.GF1289@pengutronix.de> References: <5151FB3B.4090509@helmcke.name> <20130328093633.GA1289@pengutronix.de> <51541E47.3060707@helmcke.name> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51541E47.3060707@helmcke.name> Subject: Re: [ptxdist] [PATCH] libftdi1: new package Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Thu, Mar 28, 2013 at 11:41:11AM +0100, Andreas Helmcke wrote: > Am 28.03.2013 10:36, schrieb Michael Olbrich: > > On Tue, Mar 26, 2013 at 08:47:07PM +0100, Andreas Helmcke wrote: > >> +ifdef PTXCONF_LIBFTDI1_EXAMPLES > >> + @for i in $(shell find $(LIBFTDI1_DIR)-build/examples -maxdepth 1 -type f -executable -printf "%f\n"); do \ > >> + $(call install_copy, libftdi1, 0, 0, 0755, $(LIBFTDI1_DIR)-build/examples/$$i, /usr/local/bin/$$i); \ > >> + done > > > > @cd $(LIBFTDI1_DIR)-build/examples && \ > > for i in `find maxdepth 1 -type f -executable -printf "%f\n"`; do \ > > $(call install_copy, libftdi1, 0, 0, 0755, \ > > $(LIBFTDI1_DIR)-build/examples/$$i, \ > > /usr/bin/$$i); \ > > done > > > > Note: > > [...] > > - don't use 'shell', it is executed when make starts, not when the target > > commands are executed > > I just modified the example code which gets generated by "ptxdist newpackage src-cmake-prog". > So someone should change this too. Yes, I think that's broken too. > btw: Why is ptxdist building its own host version of cmake rather than using > the one, which is installed on the build host? Cross compiling is tricky. I think I had to fix the Python detection three times when we switched to a newer cmake version... Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de