From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1UKulN-00052B-7z
	for ptxdist@pengutronix.de; Wed, 27 Mar 2013 19:07:53 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1UKulL-0003QV-5H
	for ptxdist@pengutronix.de; Wed, 27 Mar 2013 19:07:51 +0100
Date: Wed, 27 Mar 2013 19:07:51 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20130327180751.GT1289@pengutronix.de>
References: <1364230459-30588-1-git-send-email-h.feurstein@gmail.com>
	<1364230459-30588-2-git-send-email-h.feurstein@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1364230459-30588-2-git-send-email-h.feurstein@gmail.com>
Subject: Re: [ptxdist] [PATCH 2/2] qt4: install libqnmbearer only when
 networkmanager is selected
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Mar 25, 2013 at 05:54:19PM +0100, Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
>  rules/qt4.make | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rules/qt4.make b/rules/qt4.make
> index c1174f2..b5ae03a 100644
> --- a/rules/qt4.make
> +++ b/rules/qt4.make
> @@ -556,9 +556,11 @@ endif
>  ifdef PTXCONF_QT4_BUILD_NETWORK
>  	@$(call install_copy, qt4, 0, 0, 0644, -, \
>  		/usr/plugins/bearer/libqgenericbearer.$(QT4_PLUGIN_EXT))
> +ifdef PTXCONF_NETWORKMANAGER

This is not good. I try to avoid using symbols from other packages because
that break the detection when a package needs to be rebuild.

Why this change anyways? The library is not that large to make a
difference. Does it behave badly if NetworkManager is not present?

Anyways, if this is really necessary then create a QT4_NETWORKMANAGER
options, with no prompt and "default NETWORKMANAGER"

Michael

>  	@$(call install_copy, qt4, 0, 0, 0644, -, \
>  		/usr/plugins/bearer/libqnmbearer.$(QT4_PLUGIN_EXT))
>  endif
> +endif
>  ifdef PTXCONF_QT4_BUILD_PHONON
>  	@$(call install_copy, qt4, 0, 0, 0644, -, \
>  		/usr/plugins/phonon_backend/libphonon_gstreamer.$(QT4_PLUGIN_EXT))
> -- 
> 1.8.1.3
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de