From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/2] qt4: install libqnmbearer only when networkmanager is selected
Date: Wed, 27 Mar 2013 19:07:51 +0100 [thread overview]
Message-ID: <20130327180751.GT1289@pengutronix.de> (raw)
In-Reply-To: <1364230459-30588-2-git-send-email-h.feurstein@gmail.com>
On Mon, Mar 25, 2013 at 05:54:19PM +0100, Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> rules/qt4.make | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/rules/qt4.make b/rules/qt4.make
> index c1174f2..b5ae03a 100644
> --- a/rules/qt4.make
> +++ b/rules/qt4.make
> @@ -556,9 +556,11 @@ endif
> ifdef PTXCONF_QT4_BUILD_NETWORK
> @$(call install_copy, qt4, 0, 0, 0644, -, \
> /usr/plugins/bearer/libqgenericbearer.$(QT4_PLUGIN_EXT))
> +ifdef PTXCONF_NETWORKMANAGER
This is not good. I try to avoid using symbols from other packages because
that break the detection when a package needs to be rebuild.
Why this change anyways? The library is not that large to make a
difference. Does it behave badly if NetworkManager is not present?
Anyways, if this is really necessary then create a QT4_NETWORKMANAGER
options, with no prompt and "default NETWORKMANAGER"
Michael
> @$(call install_copy, qt4, 0, 0, 0644, -, \
> /usr/plugins/bearer/libqnmbearer.$(QT4_PLUGIN_EXT))
> endif
> +endif
> ifdef PTXCONF_QT4_BUILD_PHONON
> @$(call install_copy, qt4, 0, 0, 0644, -, \
> /usr/plugins/phonon_backend/libphonon_gstreamer.$(QT4_PLUGIN_EXT))
> --
> 1.8.1.3
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2013-03-27 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 16:54 [ptxdist] [PATCH 1/2] qt4: install bearer plugins only when network " Hubert Feurstein
2013-03-25 16:54 ` [ptxdist] [PATCH 2/2] qt4: install libqnmbearer only when networkmanager " Hubert Feurstein
2013-03-27 18:07 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327180751.GT1289@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox