Re: [ptxdist] [PATCH 2/2] comgt: New package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Mar 23, 2013 at 12:45:10PM +0100, Bernhard Walle wrote:
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  .../comgt.0.32/0001-Fix-cross-compilation.patch    | 22 +++++++
>  patches/comgt.0.32/series                          |  4 ++
>  rules/comgt.in                                     |  7 +++
>  rules/comgt.make                                   | 67 ++++++++++++++++++++++
>  4 files changed, 100 insertions(+)
>  create mode 100644 patches/comgt.0.32/0001-Fix-cross-compilation.patch
>  create mode 100644 patches/comgt.0.32/series
>  create mode 100644 rules/comgt.in
>  create mode 100644 rules/comgt.make
> 
> diff --git a/patches/comgt.0.32/0001-Fix-cross-compilation.patch b/patches/comgt.0.32/0001-Fix-cross-compilation.patch
> new file mode 100644
> index 0000000..b8ea7aa
> --- /dev/null
> +++ b/patches/comgt.0.32/0001-Fix-cross-compilation.patch
> @@ -0,0 +1,22 @@
> +From: Bernhard Walle <bernhard@bwalle.de>
> +Date: Wed, 25 Jul 2012 17:35:00 +0200
> +Subject: [PATCH] Fix cross compilation
> +
> +Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> +---
> + Makefile | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/Makefile b/Makefile
> +index 6028647..412a7b3 100755
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -72,8 +72,6 @@ clean:
> + 
> + 
> + comgt: comgt.o
> +-	cc comgt.o $(LDFLAGS) -o comgt
> + 
> + comgt.o: comgt.c comgt.h
> +-	cc comgt.c $(CFLAGS) 
> + 

Ahhh, why do some people think they need to write such stupid makefiles?

> diff --git a/patches/comgt.0.32/series b/patches/comgt.0.32/series
> new file mode 100644
> index 0000000..c471dfc
> --- /dev/null
> +++ b/patches/comgt.0.32/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-Fix-cross-compilation.patch
> +# 42a9d69cd806f97d2b9a444234c6afa5  - git-ptx-patches magic
> diff --git a/rules/comgt.in b/rules/comgt.in
> new file mode 100644
> index 0000000..8b1e11d
> --- /dev/null
> +++ b/rules/comgt.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config COMGT
> +	tristate
> +	prompt "comgt"
> +	help
> +	  Linux UMTS/GPRS command-line tool
> diff --git a/rules/comgt.make b/rules/comgt.make
> new file mode 100644
> index 0000000..5dbb7f1
> --- /dev/null
> +++ b/rules/comgt.make
> @@ -0,0 +1,67 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2012 by Bernhard Walle <bernhard@bwalle.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_COMGT) += comgt
> +
> +#
> +# Paths and names
> +#
> +COMGT_VERSION	:= 0.32
> +COMGT_MD5	:= db2452680c3d953631299e331daf49ef
> +COMGT		:= comgt.$(COMGT_VERSION)
> +COMGT_SUFFIX	:= tgz
> +COMGT_URL	:= $(call ptx/mirror, SF, comgt/$(COMGT).$(COMGT_SUFFIX))
> +COMGT_SOURCE	:= $(SRCDIR)/$(COMGT).$(COMGT_SUFFIX)
> +COMGT_DIR	:= $(BUILDDIR)/$(COMGT)
> +COMGT_LICENSE	:= GPL2
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#

remove the comment

> +COMGT_CONF_TOOL	:= NO
> +COMGT_MAKE_ENV	:= $(CROSS_ENV)
> +COMGT_MAKEVARS	:= $(CROSS_ENV)

no COMGT_MAKEVARS. OMGT_MAKE_ENV is enough.

> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/comgt.install:
> +	@$(call targetinfo)
> +	@install -D -m0755 $(COMGT_DIR)/comgt $(COMGT_PKGDIR)/usr/sbin/comgt
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/comgt.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, comgt)
> +	@$(call install_fixup, comgt,PRIORITY,optional)
> +	@$(call install_fixup, comgt,SECTION,base)
> +	@$(call install_fixup, comgt,AUTHOR,"Bernhard Walle <bernhard@bwalle.de>")
> +	@$(call install_fixup, comgt,DESCRIPTION,missing)
> +
> +	@$(call install_copy, comgt, 0, 0, 0755, -, /usr/sbin/comgt)
> +
> +	@$(call install_finish, comgt)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.8.2
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de