mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxd_install_shared: Fix missing links when ${src} is a symlink itself
Date: Thu, 21 Mar 2013 17:21:26 +0100	[thread overview]
Message-ID: <20130321162126.GA12397@regiomontanus.your-server.de> (raw)
In-Reply-To: <20130321154701.GA6144@pengutronix.de>

* Michael Olbrich <m.olbrich@pengutronix.de> [2013-03-21 16:47]:
> >      ptxd_install_file "${src}" "${dst}/${filename}" "${usr}" "${grp}" "${mod}" &&
> >  
> > +    src="$(readlink -f "${src}")" &&
> >      find "$(dirname "${src}")" -maxdepth 1 -type l | while read file; do
> 
> I think this would be nicer and should work too, right:
> 
>     find -H "$(dirname "${src}")" -maxdepth 1 -type l | while read file; do

That works indeed.  Should I send a new patch?


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2013-03-21 16:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 14:58 Bernhard Walle
2013-03-21 15:08 ` Bernhard Walle
2013-03-21 15:47   ` Michael Olbrich
2013-03-21 16:21     ` Bernhard Walle [this message]
2013-03-21 17:25       ` Michael Olbrich
2013-03-21 18:34         ` Bernhard Walle
2013-03-22  9:43           ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321162126.GA12397@regiomontanus.your-server.de \
    --to=bernhard@bwalle.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox