Re: [ptxdist] [PATCH] ptxd_install_shared: Fix missing links when ${src} is a symlink itself

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Mar 21, 2013 at 04:08:54PM +0100, Bernhard Walle wrote:
> When "${src}" is a symlink to some other directory, then not all
> symbolic links to the library are installed.
> 
> In my case I'm using a ct-ng-based toolchain where
> ${TOOLCHAIN_BASE}/arm-unknown-linux-gnueabi/lib/ is a symbolic link to
> sysroot/lib/. As a result, install_copy_toolchain_lib with libstdc++.so
> doesn't install the libstdc++.so.6 symbolic link and so C++ programs
> don't start.
> 
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
> First version missed the '&&'.
> 
>  scripts/lib/ptxd_make_xpkg_pkg.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
> index 476ad58..b32461e 100644
> --- a/scripts/lib/ptxd_make_xpkg_pkg.sh
> +++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
> @@ -694,6 +694,7 @@ ptxd_install_shared() {
>  
>      ptxd_install_file "${src}" "${dst}/${filename}" "${usr}" "${grp}" "${mod}" &&
>  
> +    src="$(readlink -f "${src}")" &&
>      find "$(dirname "${src}")" -maxdepth 1 -type l | while read file; do

I think this would be nicer and should work too, right:

    find -H "$(dirname "${src}")" -maxdepth 1 -type l | while read file; do

mol

>  	if [ "$(basename "$(readlink -f "${file}")")" = "${filename}" ]; then
>  	    local link="${dst}/$(basename "${file}")"
> -- 
> 1.8.2
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de