From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1UHzOJ-0004wX-Uz
	for ptxdist@pengutronix.de; Tue, 19 Mar 2013 17:27:59 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1UHzOH-0000It-Sy
	for ptxdist@pengutronix.de; Tue, 19 Mar 2013 17:27:57 +0100
Date: Tue, 19 Mar 2013 17:27:57 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20130319162757.GD30288@pengutronix.de>
References: <1363263396-10029-1-git-send-email-post@lespocky.de>
	<20130319153256.GC30288@pengutronix.de>
	<418cf186bf4178fef3675a181603dd34@idefix.lespocky.dyndns.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <418cf186bf4178fef3675a181603dd34@idefix.lespocky.dyndns.org>
Subject: Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment
 problem on arm
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Mar 19, 2013 at 04:55:37PM +0100, Alexander Dahl wrote:
> Hei Michael, 
> 
> Am 2013-03-19 16:32, schrieb Michael Olbrich:
> > On Thu, Mar 14, 2013 at 01:16:36PM +0100, Alexander Dahl wrote:
> >> We use -Wcast-align on ARMv5 platform and libmodbus3 sets -Werror
> >> which leads to a failing build in one case. This patch fixes the
> >> alignment problem. Upstream pull requested.
> > 
> > Hmm, this is just unit test stuff, right? We don't actually need this.
> 
> Yes, I think so. The targetinstall rule does not install these binaries
> anyway.
> 
> > Maybe we should do this instead:
> > 
> > LIBMODBUS3_MAKE_OPT	:= -C src
> > LIBMODBUS3_INSTALL_OPT	:= -C src install
> 
> My colleague removed 'tests' from Makefile.am, I don't know which one
> would be the best choice.

I prefer to avoid patches when possible.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de