From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1UDdLz-0001bi-8P for ptxdist@pengutronix.de; Thu, 07 Mar 2013 17:07:35 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1UDdLz-0005sf-6g for ptxdist@pengutronix.de; Thu, 07 Mar 2013 17:07:35 +0100 Date: Thu, 7 Mar 2013 17:07:35 +0100 From: Michael Olbrich Message-ID: <20130307160735.GX7949@pengutronix.de> References: <1362600041-13179-1-git-send-email-u.kleine-koenig@pengutronix.de> <5137B342.1060905@pengutronix.de> <20130306215426.GF15375@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130306215426.GF15375@pengutronix.de> Subject: Re: [ptxdist] [PATCH] git-ptx-patches: add --notes to git-format-patch if it's supported Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Wed, Mar 06, 2013 at 10:54:26PM +0100, Uwe Kleine-K=F6nig wrote: > On Wed, Mar 06, 2013 at 10:21:06PM +0100, Marc Kleine-Budde wrote: > > On 03/06/2013 09:00 PM, Uwe Kleine-K=F6nig wrote: > > > While at it also document minimal git version needed for --no-signatu= re. > > > = > > > Signed-off-by: Uwe Kleine-K=F6nig > > > --- > > > scripts/git-ptx-patches | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > = > > > diff --git a/scripts/git-ptx-patches b/scripts/git-ptx-patches > > > index 37f5d91..fadb2c1 100755 > > > --- a/scripts/git-ptx-patches > > > +++ b/scripts/git-ptx-patches > > > @@ -110,10 +110,17 @@ case "$remove_old" in > > > ;; > > > esac > > > = > > > +# git-format-patch --notes is supported since git 1.7.2 > > = > > ? > That's the "While at it" part mentioned in the commit log. I consider it > helpful when judging if it's time to remove that check. E.g. 1.7.2 means > it's in Debian squeeze. So I'd say it's safe to remove it soon. Yes but the comment is wrong '--notes' !=3D '--no-signature' > > > if git format-patch -h 2>&1 | grep -q signature; then > > > GIT_EXTRA_ARGS=3D"--no-signature" > > > fi > > > = > > > +# git-format-patch --notes is supported since git 1.7.6, but actuall= y you want > > > +# git 1.8.1-rc0 to get the notes below the --- marker > > > +if man git-format-patch | grep -q -e --notes; then > > = > > Why don't we use the same mechanism (either man or -h) to figure out if > > git supports the extra agrument? > git-format-patch -h doesn't mention --notes in 1.8.1-rc0 so I used man. > I didn't consider this to be enough to change the working way to > determine if --no-signature is supported. Those the whole thing work both ways? Will "git quiltimport" notes from the stuff below the --- marker? If not, these things will get lost easily. Michael -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de