From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Wed, 6 Mar 2013 22:54:26 +0100
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Message-ID: <20130306215426.GF15375@pengutronix.de>
References: <1362600041-13179-1-git-send-email-u.kleine-koenig@pengutronix.de>
	<5137B342.1060905@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <5137B342.1060905@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] git-ptx-patches: add --notes to
 git-format-patch if it's supported
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: ptxdist@pengutronix.de

On Wed, Mar 06, 2013 at 10:21:06PM +0100, Marc Kleine-Budde wrote:
> On 03/06/2013 09:00 PM, Uwe Kleine-K=F6nig wrote:
> > While at it also document minimal git version needed for --no-signature.
> > =

> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > ---
> >  scripts/git-ptx-patches | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > =

> > diff --git a/scripts/git-ptx-patches b/scripts/git-ptx-patches
> > index 37f5d91..fadb2c1 100755
> > --- a/scripts/git-ptx-patches
> > +++ b/scripts/git-ptx-patches
> > @@ -110,10 +110,17 @@ case "$remove_old" in
> >  		;;
> >  esac
> >  =

> > +# git-format-patch --notes is supported since git 1.7.2
> =

> ?
That's the "While at it" part mentioned in the commit log. I consider it
helpful when judging if it's time to remove that check. E.g. 1.7.2 means
it's in Debian squeeze. So I'd say it's safe to remove it soon.

> >  if git format-patch -h 2>&1 | grep -q signature; then
> >  	GIT_EXTRA_ARGS=3D"--no-signature"
> >  fi
> >  =

> > +# git-format-patch --notes is supported since git 1.7.6, but actually =
you want
> > +# git 1.8.1-rc0 to get the notes below the --- marker
> > +if man git-format-patch | grep -q -e --notes; then
> =

> Why don't we use the same mechanism (either man or -h) to figure out if
> git supports the extra agrument?
git-format-patch -h doesn't mention --notes in 1.8.1-rc0 so I used man.
I didn't consider this to be enough to change the working way to
determine if --no-signature is supported.

Best regards
Uwe

-- =

Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

-- =

ptxdist mailing list
ptxdist@pengutronix.de