Re: [ptxdist] [PATCH v2] strongswan: add package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Mar 05, 2013 at 08:37:02PM +0100, Christoph Fritz wrote:
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
>  rules/strongswan.in   |   10 ++++++++
>  rules/strongswan.make |   62 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 72 insertions(+)
>  create mode 100644 rules/strongswan.in
>  create mode 100644 rules/strongswan.make
> 
> diff --git a/rules/strongswan.in b/rules/strongswan.in
> new file mode 100644
> index 0000000..1e93801
> --- /dev/null
> +++ b/rules/strongswan.in
> @@ -0,0 +1,10 @@
> +## SECTION=networking
> +
> +config STRONGSWAN
> +	bool
> +	prompt "strongswan"
> +	help
> +	  strongSwan is a complete IPsec implementation. 
> +	  Please keep in mind to configure the kernel accordingly to fulfill
> +	  strongSwan's needs. See 'Required Kernel Modules' here:
> +	  http://wiki.strongswan.org/projects/strongswan/wiki/KernelModules
> diff --git a/rules/strongswan.make b/rules/strongswan.make
> new file mode 100644
> index 0000000..9c82672
> --- /dev/null
> +++ b/rules/strongswan.make
> @@ -0,0 +1,62 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2013 by Christoph Fritz <chf.fritz@googlemail.com>
> +#
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_STRONGSWAN) += strongswan
> +
> +#
> +# Paths and names
> +#
> +STRONGSWAN_VERSION	:= 5.0.2
> +STRONGSWAN_MD5		:= 77dc16443fd141f46183d3a4f60986ef
> +STRONGSWAN		:= strongswan-$(STRONGSWAN_VERSION)
> +STRONGSWAN_SUFFIX	:= tar.bz2
> +STRONGSWAN_URL		:= http://download.strongswan.org/$(STRONGSWAN).$(STRONGSWAN_SUFFIX)
> +STRONGSWAN_SOURCE	:= $(SRCDIR)/$(STRONGSWAN).$(STRONGSWAN_SUFFIX)
> +STRONGSWAN_DIR		:= $(BUILDDIR)/$(STRONGSWAN)
> +STRONGSWAN_LICENSE	:= GPL
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +STRONGSWAN_CONF_TOOL	:= autoconf
> +STRONGSWAN_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	--with-ipseclibdir=/usr/lib

I'm not sure if you misunderstood something, but I didn't mean that you
should remove the configure options.
You should explicitly specify all the options from the "Optional Features"
section from "./configure --help".
A good starting point  usually is to add a kconfig options for all features
that have external dependencies (don't forget the 'select' in
strongswan.in) and choose a reasonable default for all others.

It's also a good idea to run "readelf -d <binary>" to check if you missed
any dependencies.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/strongswan.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, strongswan)
> +	@$(call install_fixup, strongswan,PRIORITY,optional)
> +	@$(call install_fixup, strongswan,SECTION,base)
> +	@$(call install_fixup, strongswan,AUTHOR,"Christoph Fritz <chf.fritz@googlemail.com>")
> +	@$(call install_fixup, strongswan,DESCRIPTION,missing)
> +
> +	@$(call install_tree, strongswan, 0, 0, $(STRONGSWAN_PKGDIR)/usr/sbin, /usr/sbin)
> +	@$(call install_tree, strongswan, 0, 0, $(STRONGSWAN_PKGDIR)/usr/libexec, /usr/libexec)
> +	@$(call install_tree, strongswan, 0, 0, $(STRONGSWAN_PKGDIR)/usr/lib, /usr/lib)
> +	@$(call install_copy, strongswan, 0, 0, 0600, /etc/ipsec.d/private)
> +	@$(call install_copy, strongswan, 0, 0, 0644, /etc/ipsec.d/certs)
> +	@$(call install_copy, strongswan, 0, 0, 0644, /etc/ipsec.d/cacerts)
> +
> +	@$(call install_finish, strongswan)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.7.10.4
> 
> 
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de