mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] Add ${SYSROOT}/kernel-headers to include path
Date: Wed, 20 Feb 2013 19:24:47 +0100	[thread overview]
Message-ID: <20130220182447.GE5360@pengutronix.de> (raw)
In-Reply-To: <1361263696-15206-1-git-send-email-alexander.stein@systec-electronic.com>

On Tue, Feb 19, 2013 at 09:48:16AM +0100, Alexander Stein wrote:
> This is needed to use the kernel-headers in cmake based projects.

I understand why you want this, however, this will likly break other
packages. This adds the kernel headers to the search path of all packages,
and there will be packages, that cannot be build with newer kernel headers.
Usually because they need old obsolete APIs that got removed in newer
kernel versions.
This is something I have to fix whenever I release a Toolchain with newer
kernel headers. And with the variable version of the kernel headers this
would make things quite difficult to handle.

I think you'll need to patch such packages to accept
-DKERNEL_INCUDE_DIR=/some/path or something like that.

Michael

> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  scripts/lib/ptxd_make_00-init.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/lib/ptxd_make_00-init.sh b/scripts/lib/ptxd_make_00-init.sh
> index 6257648..9927527 100644
> --- a/scripts/lib/ptxd_make_00-init.sh
> +++ b/scripts/lib/ptxd_make_00-init.sh
> @@ -128,12 +128,12 @@ ptxd_init_sysroot_toolchain() {
>  #
>  ptxd_init_ptxdist_path_sysroot() {
>      local sysroot="$(ptxd_get_ptxconf PTXCONF_SYSROOT_TARGET)"
> -    local sysroot_prefix="${sysroot}:${sysroot}/usr"
> +    local sysroot_prefix="${sysroot}:${sysroot}/usr:${sysroot}/kernel-headers"
>  
>      local sysroot_base_platform
>      if ptxd_init_get_sysroot_base_platform; then
>  	sysroot="${sysroot}:${sysroot_base_platform}"
> -	sysroot_prefix="${sysroot_prefix}:${sysroot_base_platform}:${sysroot_base_platform}/usr"
> +	sysroot_prefix="${sysroot_prefix}:${sysroot_base_platform}:${sysroot_base_platform}/usr:${sysroot_base_platform}/kernel-headers"
>      fi
>  
>      local sysroot_all="${sysroot}"
> -- 
> 1.8.1.2
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2013-02-20 18:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19  8:48 Alexander Stein
2013-02-20 18:24 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130220182447.GE5360@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox