From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1U8E3W-0004KO-TU
	for ptxdist@pengutronix.de; Wed, 20 Feb 2013 19:06:10 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1U8E3W-0002XU-T2
	for ptxdist@pengutronix.de; Wed, 20 Feb 2013 19:06:10 +0100
Date: Wed, 20 Feb 2013 19:06:10 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20130220180610.GD5360@pengutronix.de>
References: <1361014408-41323-1-git-send-email-bernhard@bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1361014408-41323-1-git-send-email-bernhard@bwalle.de>
Subject: Re: [ptxdist] [PATCH] kconfig: Fix build on Darwin
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sat, Feb 16, 2013 at 12:33:28PM +0100, Bernhard Walle wrote:
> Darwin 12.2.0 (Mac OS 10.8) defines CIRCLEQ_HEAD but doesn't define
> CIRCLEQ_HEAD_INITIALIZER. Since mconf.c uses CIRCLEQ_HEAD_INITIALIZER,
> the build fails.
> 
> A simple and safe fix is to always use our own copy of the CIRCLEQ_
> macros on every platform. Include "missing.h" and don't include
> <sys/queue.h". That works also on Linux, verified on current Arch Linux
> with glibc 2.17.

I prefer a AC_CHECK_HEADER in configure.ac and the use
"#ifdef SYS_QUEUE_H", I think.
Also, you need to add a patch to scripts/ptx-modifications/ so this is not
lost, when we update to a newer kconfig version.

Michael

> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  scripts/kconfig/expr.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h
> index 59402a3..041b08e 100644
> --- a/scripts/kconfig/expr.h
> +++ b/scripts/kconfig/expr.h
> @@ -12,7 +12,6 @@ extern "C" {
>  
>  #include <assert.h>
>  #include <stdio.h>
> -#include <sys/queue.h>
>  #ifndef __cplusplus
>  #include <stdbool.h>
>  #endif
> -- 
> 1.8.1.3
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de