Re: [ptxdist] [PATCH] kconfig: Fix build on Darwin

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Feb 16, 2013 at 12:33:28PM +0100, Bernhard Walle wrote:
> Darwin 12.2.0 (Mac OS 10.8) defines CIRCLEQ_HEAD but doesn't define
> CIRCLEQ_HEAD_INITIALIZER. Since mconf.c uses CIRCLEQ_HEAD_INITIALIZER,
> the build fails.
> 
> A simple and safe fix is to always use our own copy of the CIRCLEQ_
> macros on every platform. Include "missing.h" and don't include
> <sys/queue.h". That works also on Linux, verified on current Arch Linux
> with glibc 2.17.

I prefer a AC_CHECK_HEADER in configure.ac and the use
"#ifdef SYS_QUEUE_H", I think.
Also, you need to add a patch to scripts/ptx-modifications/ so this is not
lost, when we update to a newer kconfig version.

Michael

> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  scripts/kconfig/expr.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h
> index 59402a3..041b08e 100644
> --- a/scripts/kconfig/expr.h
> +++ b/scripts/kconfig/expr.h
> @@ -12,7 +12,6 @@ extern "C" {
>  
>  #include <assert.h>
>  #include <stdio.h>
> -#include <sys/queue.h>
>  #ifndef __cplusplus
>  #include <stdbool.h>
>  #endif
> -- 
> 1.8.1.3
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de