From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Tqlvk-0002MJ-5K
	for ptxdist@pengutronix.de; Thu, 03 Jan 2013 15:38:00 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Tqlvk-0001yw-4K
	for ptxdist@pengutronix.de; Thu, 03 Jan 2013 15:38:00 +0100
Date: Thu, 3 Jan 2013 15:38:00 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20130103143800.GD23783@pengutronix.de>
References: <50ABFF10.9090103@math.spbu.ru>
 <50C28843.4040505@math.spbu.ru>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <50C28843.4040505@math.spbu.ru>
Subject: Re: [ptxdist] PATCH: Fix sqlite conf environment
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sat, Dec 08, 2012 at 04:22:27AM +0400, Kirill Smirnov wrote:
> Please, any feedback on this. Did I do anything wrong?

I forgot about this.

> On 21.11.2012 02:07, Kirill Smirnov wrote:
> >The attached patch correctly sets up CPPFLAGS variable for sqlite
> >package and contains a minor cosmetic fix.

Please end a canonical patch (with 'git sent-email' or (git format-patch').

> >Otherwise configure script cannot find external libraries and headers
> >(such as readline).

Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
why you're getting this error and I don't.

> >--
> >Kirill
> >
> >
> > diff --git a/rules/sqlite.make b/rules/sqlite.make
> > index 0ff4c86..25ff3b7 100644
> > --- a/rules/sqlite.make
> > +++ b/rules/sqlite.make
> > @@ -34,12 +34,13 @@ SQLITE_LICENSE	:= public_domain
> >  # ----------------------------------------------------------------------------
> 
> >  SQLITE_CONF_ENV := \
> > -	CPPFLAGS=" \
> > +	$(CROSS_ENV) \

This looks ok.

> > +	CPPFLAGS="$(CROSS_CPPFLAGS) \

With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
not needed any more.

Michael

> >  	-DSQLITE_ENABLE_COLUMN_METADATA \
> >  	-DSQLITE_ENABLE_FTS3 \
> >  	-DSQLITE_ENABLE_RTREE=1 \
> >  	-DSQLITE_ENABLE_UNLOCK_NOTIFY \
> > -	-DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1\
> > +	-DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
> >  	-DSQLITE_OMIT_LOOKASIDE=1 \
> >  	-DSQLITE_SECURE_DELETE \
> >  	-DSQLITE_SOUNDEX=1 \
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de