From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] PATCH: Fix sqlite conf environment
Date: Thu, 3 Jan 2013 15:38:00 +0100 [thread overview]
Message-ID: <20130103143800.GD23783@pengutronix.de> (raw)
In-Reply-To: <50C28843.4040505@math.spbu.ru>
On Sat, Dec 08, 2012 at 04:22:27AM +0400, Kirill Smirnov wrote:
> Please, any feedback on this. Did I do anything wrong?
I forgot about this.
> On 21.11.2012 02:07, Kirill Smirnov wrote:
> >The attached patch correctly sets up CPPFLAGS variable for sqlite
> >package and contains a minor cosmetic fix.
Please end a canonical patch (with 'git sent-email' or (git format-patch').
> >Otherwise configure script cannot find external libraries and headers
> >(such as readline).
Interresting, the CROSS_ENV part is definitively correct, but I'm not sure,
why you're getting this error and I don't.
> >--
> >Kirill
> >
> >
> > diff --git a/rules/sqlite.make b/rules/sqlite.make
> > index 0ff4c86..25ff3b7 100644
> > --- a/rules/sqlite.make
> > +++ b/rules/sqlite.make
> > @@ -34,12 +34,13 @@ SQLITE_LICENSE := public_domain
> > # ----------------------------------------------------------------------------
>
> > SQLITE_CONF_ENV := \
> > - CPPFLAGS=" \
> > + $(CROSS_ENV) \
This looks ok.
> > + CPPFLAGS="$(CROSS_CPPFLAGS) \
With the latest changes to ptxdist CROSS_CPPFLAGS is now empty, so this is
not needed any more.
Michael
> > -DSQLITE_ENABLE_COLUMN_METADATA \
> > -DSQLITE_ENABLE_FTS3 \
> > -DSQLITE_ENABLE_RTREE=1 \
> > -DSQLITE_ENABLE_UNLOCK_NOTIFY \
> > - -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1\
> > + -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
> > -DSQLITE_OMIT_LOOKASIDE=1 \
> > -DSQLITE_SECURE_DELETE \
> > -DSQLITE_SOUNDEX=1 \
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2013-01-03 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 22:07 Kirill Smirnov
2012-12-08 0:22 ` Kirill Smirnov
2013-01-03 14:38 ` Michael Olbrich [this message]
2013-01-04 14:59 ` Kirill Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103143800.GD23783@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox