[ptxdist] host-dtc not compiling

[ptxdist] host-dtc not compiling

[Tim Sander]

Hi

I have the problem that host-dtc and dtc are not compiling with OSELAS 
2012.12.0 and ptxdist 2012.12.0 (and also 2012.11.0). There are some bogus 
messages that variables are initialized but unused. But they are used later 
on? I have not found the place where this warning flag of unused variables is 
set?

Best regards
Tim

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] host-dtc not compiling

[Bernhard Walle]

Hi Tim,

* Tim Sander <tim01@vlsi.informatik.tu-darmstadt.de> [2012-12-20 16:09]:
> 
> I have the problem that host-dtc and dtc are not compiling with OSELAS 
> 2012.12.0 and ptxdist 2012.12.0 (and also 2012.11.0). There are some bogus 
> messages that variables are initialized but unused. But they are used later 
> on? I have not found the place where this warning flag of unused variables is 
> set?

Maybe -Werror? In the Makefile of dtc itself? Can you post the error log
including the compiler call.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] host-dtc not compiling

[Tim Sander]

Hi Bernhard
> * Tim Sander <tim01@vlsi.informatik.tu-darmstadt.de> [2012-12-20 16:09]:
> > I have the problem that host-dtc and dtc are not compiling with OSELAS
> > 2012.12.0 and ptxdist 2012.12.0 (and also 2012.11.0). There are some
> > bogus messages that variables are initialized but unused. But they are
> > used later on? I have not found the place where this warning flag of
> > unused variables is set?
> 
> Maybe -Werror? In the Makefile of dtc itself? Can you post the error log
> including the compiler call.
Its -Werror=unused-but-set-variable but its not set in host-dtc.make 
I didn't found the source of the flags but maybe its from the 2012.12 toolchain?

Best regards
Tim

the log:
------------------------
target: host-dtc.extract
------------------------

extract: pkg_src=ptx/src/dtc-v1.3.0.tgz
extract: pkg_extract_dir=ptx/platform-zynq/build-host/dtc-v1.3.0
patchin: no patches found
finished target host-dtc.extract

-----------------------------
target: host-dtc.extract.post
-----------------------------

finished target host-dtc.extract.post

------------------------
target: host-dtc.prepare
------------------------

pkg_deprecated_env="CC="gcc" CXX="g++" CPPFLAGS="-isystem /home/sander/speedy/zynq/ptx/platform-zynq/sysroot-host/include" LDFLAGS="-L/home/sander/speedy/zynq/ptx/platform-
zynq/sysroot-host/lib -Wl,-rpath -Wl,/home/sander/speedy/zynq/ptx/platform-zynq/sysroot-host/lib -Wl,-rpath -
Wl,/this/is/a/long/path/to/make/host/tools/relocateable/with/chrpath/when/using/dev/packages" PKG_CONFIG_PATH="" PKG_CONFIG_LIBDIR="/home/sander/speedy/zynq/ptx/platform-zynq/sysroot-
host/lib/pkgconfig:/home/sander/speedy/zynq/ptx/platform-zynq/sysroot-host/share/pkgconfig" PYTHONPATH="/home/sander/speedy/zynq/ptx/platform-zynq/sysroot-host/lib/python2.7/site-packages""

No prepare tool found. Do nothing.
finished target host-dtc.prepare

------------------------
target: host-dtc.compile
------------------------

make[1]: Entering directory `/home/sander/speedy/zynq/ptx/platform-zynq/build-host/dtc-v1.3.0'
cc -I libfdt -MM -MG -MT "tests/dumptrees.o tests/dumptrees.d" tests/dumptrees.c > tests/dumptrees.d
cc -I libfdt -MM -MG -MT "tests/trees.o tests/trees.d" tests/trees.S > tests/trees.d
cc -I libfdt -MM -MG -MT "tests/value-labels.o tests/value-labels.d" tests/value-labels.c > tests/value-labels.d
cc -I libfdt -MM -MG -MT "tests/testutils.o tests/testutils.d" tests/testutils.c > tests/testutils.d
cc -I libfdt -MM -MG -MT "tests/asm_tree_dump.o tests/asm_tree_dump.d" tests/asm_tree_dump.c > tests/asm_tree_dump.d
cc -I libfdt -MM -MG -MT "tests/truncated_property.o tests/truncated_property.d" tests/truncated_property.c > tests/truncated_property.d
cc -I libfdt -MM -MG -MT "tests/path_offset_aliases.o tests/path_offset_aliases.d" tests/path_offset_aliases.c > tests/path_offset_aliases.d
cc -I libfdt -MM -MG -MT "tests/add_subnode_with_nops.o tests/add_subnode_with_nops.d" tests/add_subnode_with_nops.c > tests/add_subnode_with_nops.d
cc -I libfdt -MM -MG -MT "tests/dtbs_equal_unordered.o tests/dtbs_equal_unordered.d" tests/dtbs_equal_unordered.c > tests/dtbs_equal_unordered.d
cc -I libfdt -MM -MG -MT "tests/dtb_reverse.o tests/dtb_reverse.d" tests/dtb_reverse.c > tests/dtb_reverse.d
cc -I libfdt -MM -MG -MT "tests/dtbs_equal_ordered.o tests/dtbs_equal_ordered.d" tests/dtbs_equal_ordered.c > tests/dtbs_equal_ordered.d
cc -I libfdt -MM -MG -MT "tests/extra-terminating-null.o tests/extra-terminating-null.d" tests/extra-terminating-null.c > tests/extra-terminating-null.d
cc -I libfdt -MM -MG -MT "tests/incbin.o tests/incbin.d" tests/incbin.c > tests/incbin.d
cc -I libfdt -MM -MG -MT "tests/boot-cpuid.o tests/boot-cpuid.d" tests/boot-cpuid.c > tests/boot-cpuid.d
cc -I libfdt -MM -MG -MT "tests/phandle_format.o tests/phandle_format.d" tests/phandle_format.c > tests/phandle_format.d
cc -I libfdt -MM -MG -MT "tests/path-references.o tests/path-references.d" tests/path-references.c > tests/path-references.d
cc -I libfdt -MM -MG -MT "tests/references.o tests/references.d" tests/references.c > tests/references.d
cc -I libfdt -MM -MG -MT "tests/string_escapes.o tests/string_escapes.d" tests/string_escapes.c > tests/string_escapes.d
cc -I libfdt -MM -MG -MT "tests/del_property.o tests/del_property.d" tests/del_property.c > tests/del_property.d
cc -I libfdt -MM -MG -MT "tests/rw_tree1.o tests/rw_tree1.d" tests/rw_tree1.c > tests/rw_tree1.d
cc -I libfdt -MM -MG -MT "tests/setprop.o tests/setprop.d" tests/setprop.c > tests/setprop.d
cc -I libfdt -MM -MG -MT "tests/del_node.o tests/del_node.d" tests/del_node.c > tests/del_node.d
cc -I libfdt -MM -MG -MT "tests/open_pack.o tests/open_pack.d" tests/open_pack.c > tests/open_pack.d
cc -I libfdt -MM -MG -MT "tests/set_name.o tests/set_name.d" tests/set_name.c > tests/set_name.d
cc -I libfdt -MM -MG -MT "tests/mangle-layout.o tests/mangle-layout.d" tests/mangle-layout.c > tests/mangle-layout.d
cc -I libfdt -MM -MG -MT "tests/move_and_save.o tests/move_and_save.d" tests/move_and_save.c > tests/move_and_save.d
cc -I libfdt -MM -MG -MT "tests/nopulate.o tests/nopulate.d" tests/nopulate.c > tests/nopulate.d
cc -I libfdt -MM -MG -MT "tests/sw_tree1.o tests/sw_tree1.d" tests/sw_tree1.c > tests/sw_tree1.d
cc -I libfdt -MM -MG -MT "tests/nop_node.o tests/nop_node.d" tests/nop_node.c > tests/nop_node.d
cc -I libfdt -MM -MG -MT "tests/nop_property.o tests/nop_property.d" tests/nop_property.c > tests/nop_property.d
cc -I libfdt -MM -MG -MT "tests/setprop_inplace.o tests/setprop_inplace.d" tests/setprop_inplace.c > tests/setprop_inplace.d
cc -I libfdt -MM -MG -MT "tests/notfound.o tests/notfound.d" tests/notfound.c > tests/notfound.d
cc -I libfdt -MM -MG -MT "tests/get_alias.o tests/get_alias.d" tests/get_alias.c > tests/get_alias.d
cc -I libfdt -MM -MG -MT "tests/node_offset_by_compatible.o tests/node_offset_by_compatible.d" tests/node_offset_by_compatible.c > tests/node_offset_by_compatible.d
cc -I libfdt -MM -MG -MT "tests/node_check_compatible.o tests/node_check_compatible.d" tests/node_check_compatible.c > tests/node_check_compatible.d
cc -I libfdt -MM -MG -MT "tests/node_offset_by_phandle.o tests/node_offset_by_phandle.d" tests/node_offset_by_phandle.c > tests/node_offset_by_phandle.d
cc -I libfdt -MM -MG -MT "tests/node_offset_by_prop_value.o tests/node_offset_by_prop_value.d" tests/node_offset_by_prop_value.c > tests/node_offset_by_prop_value.d
cc -I libfdt -MM -MG -MT "tests/parent_offset.o tests/parent_offset.d" tests/parent_offset.c > tests/parent_offset.d
cc -I libfdt -MM -MG -MT "tests/get_path.o tests/get_path.d" tests/get_path.c > tests/get_path.d
cc -I libfdt -MM -MG -MT "tests/get_phandle.o tests/get_phandle.d" tests/get_phandle.c > tests/get_phandle.d
cc -I libfdt -MM -MG -MT "tests/supernode_atdepth_offset.o tests/supernode_atdepth_offset.d" tests/supernode_atdepth_offset.c > tests/supernode_atdepth_offset.d
cc -I libfdt -MM -MG -MT "tests/getprop.o tests/getprop.d" tests/getprop.c > tests/getprop.d
cc -I libfdt -MM -MG -MT "tests/get_name.o tests/get_name.d" tests/get_name.c > tests/get_name.d
cc -I libfdt -MM -MG -MT "tests/path_offset.o tests/path_offset.d" tests/path_offset.c > tests/path_offset.d
cc -I libfdt -MM -MG -MT "tests/subnode_offset.o tests/subnode_offset.d" tests/subnode_offset.c > tests/subnode_offset.d
cc -I libfdt -MM -MG -MT "tests/find_property.o tests/find_property.d" tests/find_property.c > tests/find_property.d
cc -I libfdt -MM -MG -MT "libfdt/fdt_strerror.o libfdt/fdt_strerror.d" libfdt/fdt_strerror.c > libfdt/fdt_strerror.d
cc -I libfdt -MM -MG -MT "tests/root_node.o tests/root_node.d" tests/root_node.c > tests/root_node.d
cc -I libfdt -MM -MG -MT "tests/get_mem_rsv.o tests/get_mem_rsv.d" tests/get_mem_rsv.c > tests/get_mem_rsv.d
cc -I libfdt -MM -MG -MT "libfdt/fdt_rw.o libfdt/fdt_rw.d" libfdt/fdt_rw.c > libfdt/fdt_rw.d
cc -I libfdt -MM -MG -MT "libfdt/fdt_sw.o libfdt/fdt_sw.d" libfdt/fdt_sw.c > libfdt/fdt_sw.d
cc -I libfdt -MM -MG -MT "libfdt/fdt_wip.o libfdt/fdt_wip.d" libfdt/fdt_wip.c > libfdt/fdt_wip.d
cc -I libfdt -MM -MG -MT "libfdt/fdt_ro.o libfdt/fdt_ro.d" libfdt/fdt_ro.c > libfdt/fdt_ro.d
cc -I libfdt -MM -MG -MT "libfdt/fdt.o libfdt/fdt.d" libfdt/fdt.c > libfdt/fdt.d
cc -I libfdt -MM -MG -MT "ftdump.o ftdump.d" ftdump.c > ftdump.d
flex -oconvert-dtsv0-lexer.lex.c convert-dtsv0-lexer.l
cc -I libfdt -MM -MG -MT "util.o util.d" util.c > util.d
cc -I libfdt -MM -MG -MT "srcpos.o srcpos.d" srcpos.c > srcpos.d
cc -I libfdt -MM -MG -MT "treesource.o treesource.d" treesource.c > treesource.d
bison -d dtc-parser.y
cc -I libfdt -MM -MG -MT "livetree.o livetree.d" livetree.c > livetree.d
cc -I libfdt -MM -MG -MT "fstree.o fstree.d" fstree.c > fstree.d
flex -odtc-lexer.lex.c dtc-lexer.l
cc -I libfdt -MM -MG -MT "flattree.o flattree.d" flattree.c > flattree.d
cc -I libfdt -MM -MG -MT "dtc.o dtc.d" dtc.c > dtc.d
cc -I libfdt -MM -MG -MT "data.o data.d" data.c > data.d
cc -I libfdt -MM -MG -MT "checks.o checks.d" checks.c > checks.d
cc -I libfdt -MM -MG -MT "convert-dtsv0-lexer.lex.o convert-dtsv0-lexer.lex.d" convert-dtsv0-lexer.lex.c > convert-dtsv0-lexer.lex.d
cc -I libfdt -MM -MG -MT "dtc-parser.tab.o dtc-parser.tab.d" dtc-parser.tab.c > dtc-parser.tab.d
cc -I libfdt -MM -MG -MT "dtc-lexer.lex.o dtc-lexer.lex.d" dtc-lexer.lex.c > dtc-lexer.lex.d
make[1]: Leaving directory `/home/sander/speedy/zynq/ptx/platform-zynq/build-host/dtc-v1.3.0'
make[1]: Entering directory `/home/sander/speedy/zynq/ptx/platform-zynq/build-host/dtc-v1.3.0'
set -e; echo '  CHK version_gen.h'; mkdir -p ./;        (echo "#define DTC_VERSION \"DTC 1.3.0-g6b644e48-dirty\""; ) < Makefile > version_gen.h.tmp; if [ -r version_gen.h ] && cmp -s version_gen.h 
version_gen.h.tmp; then rm -f version_gen.h.tmp; else echo '       UPD version_gen.h'; mv -f version_gen.h.tmp version_gen.h; fi;
        CHK version_gen.h
        UPD version_gen.h
cc -I libfdt -MM -MG -MT "dtc.o dtc.d" dtc.c > dtc.d
make[1]: Leaving directory `/home/sander/speedy/zynq/ptx/platform-zynq/build-host/dtc-v1.3.0'
make[1]: Entering directory `/home/sander/speedy/zynq/ptx/platform-zynq/build-host/dtc-v1.3.0'
set -e; echo '  CHK version_gen.h'; mkdir -p ./;        (echo "#define DTC_VERSION \"DTC 1.3.0-g6b644e48-dirty\""; ) < Makefile > version_gen.h.tmp; if [ -r version_gen.h ] && cmp -s version_gen.h 
version_gen.h.tmp; then rm -f version_gen.h.tmp; else echo '       UPD version_gen.h'; mv -f version_gen.h.tmp version_gen.h; fi;
        CHK version_gen.h
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o convert-dtsv0-lexer.lex.o -c convert-dtsv0-
lexer.lex.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o srcpos.o -c srcpos.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o util.o -c util.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o checks.o -c checks.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o dtc.o -c dtc.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o data.o -c data.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o flattree.o -c flattree.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o fstree.o -c fstree.c
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o livetree.o -c livetree.c
dtc.c: In function 'main':
dtc.c:102:17: error: variable 'check' set but not used [-Werror=unused-but-set-variable]
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o treesource.o -c treesource.c
cc1: all warnings being treated as errors
make[1]: *** [dtc.o] Error 1
make[1]: *** Waiting for unfinished jobs....
flattree.c: In function 'flat_read_mem_reserve':
flattree.c:700:14: error: variable 'p' set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make[1]: *** [flattree.o] Error 1
cc -I libfdt -g -Os -fPIC -Werror -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -o dtc-lexer.lex.o -c dtc-lexer.lex.c
make[1]: Leaving directory `/home/sander/speedy/zynq/ptx/platform-zynq/build-host/dtc-v1.3.0'
make: *** [/home/sander/speedy/zynq/ptx/platform-zynq/state/host-dtc.compile] Error 2

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] host-dtc not compiling

[Bernhard Walle]

Hi Tim,

* Tim Sander <tim01@vlsi.informatik.tu-darmstadt.de> [2012-12-20 17:23]:
> > * Tim Sander <tim01@vlsi.informatik.tu-darmstadt.de> [2012-12-20 16:09]:
> > > I have the problem that host-dtc and dtc are not compiling with OSELAS
> > > 2012.12.0 and ptxdist 2012.12.0 (and also 2012.11.0). There are some
> > > bogus messages that variables are initialized but unused. But they are
> > > used later on? I have not found the place where this warning flag of
> > > unused variables is set?
> > 
> > Maybe -Werror? In the Makefile of dtc itself? Can you post the error log
> > including the compiler call.
> Its -Werror=unused-but-set-variable but its not set in host-dtc.make 
> I didn't found the source of the flags but maybe its from the 2012.12 toolchain?

It's set in the Makefile of dtc:

    CPPFLAGS = -I libfdt
    WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \
            -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls
    CFLAGS = -g -Os -fPIC -Werror $(WARNINGS)

Since we're talking about host-dtc, the OSELAS.Toolchain is not used but
the toolchain on your host.

You have to patch the source code and/or the Makefile.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] host-dtc not compiling

[Michael Olbrich]

Hi,

On Thu, Dec 20, 2012 at 04:09:34PM +0100, Tim Sander wrote:
> I have the problem that host-dtc and dtc are not compiling with OSELAS 
> 2012.12.0 and ptxdist 2012.12.0 (and also 2012.11.0). There are some bogus 
> messages that variables are initialized but unused. But they are used later 
> on? I have not found the place where this warning flag of unused variables is 
> set?

As Bernhard already said, you need to patch the Makefile. However, it is
unlikely, that you actually need this package. For all new kernels the dtc
from the kernel source should be used (PTXCONF_DTC_KERNEL).

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] host-dtc not compiling

[Tim Sander]

Hi Michael
> As Bernhard already said, you need to patch the Makefile. However, it is
> unlikely, that you actually need this package. For all new kernels the dtc
> from the kernel source should be used (PTXCONF_DTC_KERNEL).
Ah, thats better, somehow i missed this option.

Is there also an option available to append the dtb to the kernel zImage?

Guten Rutsch
Tim

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] host-dtc not compiling

[Michael Olbrich]

On Fri, Dec 21, 2012 at 03:59:58PM +0100, Tim Sander wrote:
> > As Bernhard already said, you need to patch the Makefile. However, it is
> > unlikely, that you actually need this package. For all new kernels the dtc
> > from the kernel source should be used (PTXCONF_DTC_KERNEL).
> Ah, thats better, somehow i missed this option.
> 
> Is there also an option available to append the dtb to the kernel zImage?

Not directly. But it's easy to create a make target for it. It's just
"cat $kernel $dtb > $newimage".

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de