mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] toolchain-target.cmake.in: fix system includes
@ 2012-12-12 14:12 Andreas Bießmann
  2012-12-18 18:52 ` Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Bießmann @ 2012-12-12 14:12 UTC (permalink / raw)
  To: PTXdist list; +Cc: Tim Niemeyer

When playing around with xenomai we found out that the additional added
xenomai includes had lower priority than the system includes (concrete the
PTXDIST_PATH_SYSROOT_PREFIX).  This is due to the ptxdist cmake adoption did
not export sysroot include path as system include path. To ensure a higher
priority than other 'system includes' append the ptxdist sysroot includes at
the topmost place in the system includes search path.

Signed-off-by: Tim Niemeyer <tim.niemeyer@corscience.de>
Signed-off-by: Andreas Bießmann <andreas.biessmann@corscience.de>
---
 config/cmake/toolchain-target.cmake.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/cmake/toolchain-target.cmake.in b/config/cmake/toolchain-target.cmake.in
index d316db5..6029e40 100644
--- a/config/cmake/toolchain-target.cmake.in
+++ b/config/cmake/toolchain-target.cmake.in
@@ -17,7 +17,7 @@ SET(CMAKE_CXX_COMPILER			@CXX@)
 SET(CMAKE_FIND_ROOT_PATH		@SYSROOT@)
 
 # additional search directories
-include_directories(			@INCLUDE_DIRECTORIES@)
+include_directories(BEFORE SYSTEM	@INCLUDE_DIRECTORIES@)
 link_directories(			@LINK_DIRECTORIES@)
 
 # search for programs in the build host directories
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [PATCH] toolchain-target.cmake.in: fix system includes
  2012-12-12 14:12 [ptxdist] [PATCH] toolchain-target.cmake.in: fix system includes Andreas Bießmann
@ 2012-12-18 18:52 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2012-12-18 18:52 UTC (permalink / raw)
  To: ptxdist

On Wed, Dec 12, 2012 at 03:12:37PM +0100, Andreas Bießmann wrote:
> When playing around with xenomai we found out that the additional added
> xenomai includes had lower priority than the system includes (concrete the
> PTXDIST_PATH_SYSROOT_PREFIX).  This is due to the ptxdist cmake adoption did
> not export sysroot include path as system include path. To ensure a higher
> priority than other 'system includes' append the ptxdist sysroot includes at
> the topmost place in the system includes search path.
> 
> Signed-off-by: Tim Niemeyer <tim.niemeyer@corscience.de>
> Signed-off-by: Andreas Bießmann <andreas.biessmann@corscience.de>
> ---
>  config/cmake/toolchain-target.cmake.in |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/cmake/toolchain-target.cmake.in b/config/cmake/toolchain-target.cmake.in
> index d316db5..6029e40 100644
> --- a/config/cmake/toolchain-target.cmake.in
> +++ b/config/cmake/toolchain-target.cmake.in
> @@ -17,7 +17,7 @@ SET(CMAKE_CXX_COMPILER			@CXX@)
>  SET(CMAKE_FIND_ROOT_PATH		@SYSROOT@)
>  
>  # additional search directories
> -include_directories(			@INCLUDE_DIRECTORIES@)
> +include_directories(BEFORE SYSTEM	@INCLUDE_DIRECTORIES@)
>  link_directories(			@LINK_DIRECTORIES@)

I think with the latest changes in PTXdist these lines should be completely
removed.

Michael

>  # search for programs in the build host directories
> -- 
> 1.7.10.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-18 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-12 14:12 [ptxdist] [PATCH] toolchain-target.cmake.in: fix system includes Andreas Bießmann
2012-12-18 18:52 ` Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox