From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] toolchain-target.cmake.in: fix system includes
Date: Tue, 18 Dec 2012 19:52:51 +0100 [thread overview]
Message-ID: <20121218185251.GT32091@pengutronix.de> (raw)
In-Reply-To: <1355321557-14418-1-git-send-email-andreas.biessmann@corscience.de>
On Wed, Dec 12, 2012 at 03:12:37PM +0100, Andreas Bießmann wrote:
> When playing around with xenomai we found out that the additional added
> xenomai includes had lower priority than the system includes (concrete the
> PTXDIST_PATH_SYSROOT_PREFIX). This is due to the ptxdist cmake adoption did
> not export sysroot include path as system include path. To ensure a higher
> priority than other 'system includes' append the ptxdist sysroot includes at
> the topmost place in the system includes search path.
>
> Signed-off-by: Tim Niemeyer <tim.niemeyer@corscience.de>
> Signed-off-by: Andreas Bießmann <andreas.biessmann@corscience.de>
> ---
> config/cmake/toolchain-target.cmake.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/cmake/toolchain-target.cmake.in b/config/cmake/toolchain-target.cmake.in
> index d316db5..6029e40 100644
> --- a/config/cmake/toolchain-target.cmake.in
> +++ b/config/cmake/toolchain-target.cmake.in
> @@ -17,7 +17,7 @@ SET(CMAKE_CXX_COMPILER @CXX@)
> SET(CMAKE_FIND_ROOT_PATH @SYSROOT@)
>
> # additional search directories
> -include_directories( @INCLUDE_DIRECTORIES@)
> +include_directories(BEFORE SYSTEM @INCLUDE_DIRECTORIES@)
> link_directories( @LINK_DIRECTORIES@)
I think with the latest changes in PTXdist these lines should be completely
removed.
Michael
> # search for programs in the build host directories
> --
> 1.7.10.4
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2012-12-18 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 14:12 Andreas Bießmann
2012-12-18 18:52 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218185251.GT32091@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox