Re: [ptxdist] [PATCH] fix typo in bash_completion

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Thu, Dec 13, 2012 at 01:10:33PM +0100, Daniel Kriesten wrote:
> may be you can once more lend my a hand …
> 
> As my Mac has Bash version 3, which is AFAIK deprecated for bash completion,
> I changed the script just to fit my needs.
> 
> On my linux box (recent Gentoo, bash 4.2.37) the issue is an other. If I log
> in, the completion is not loaded. If I start a new shell, the completion
> works. This seems to be related to the line
> 
> if have ptxdist
> 
> and the way Gentoo handles bash completion and the way I installed ptxdist.
> As far as I can see, ptxdist is not in the path when the completion scripts
> are executed at login as this is done by the global /etc/profile early in
> session startup. Simply removing the if statement solves this for me. But I
> guess there is a reason to check for ptxdist?

The ptxdist bash_completion script should not be sourced directly. 'have'
is defined by bash_completion before it sources the application specific
scripts and later undefined. At least that's how it works on Debian. I have
a .bash_completion like this:
--------------------------------------
. /path/to/ptxdist/scripts/bash_completion

complete -F _ptxdist_completion p
--------------------------------------

Note: for this to work 'ptxdist' must be found in PATH when this is loaded.
I suppose you could also define 'have' in a way that it is always
successful before sourcing scripts/bash_completion

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de