From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Thz4Z-00070Q-3U
	for ptxdist@pengutronix.de; Mon, 10 Dec 2012 09:50:47 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Thz4Z-0004Sd-2Q
	for ptxdist@pengutronix.de; Mon, 10 Dec 2012 09:50:47 +0100
Date: Mon, 10 Dec 2012 09:50:47 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20121210085047.GJ26985@pengutronix.de>
References: <306311DA-E5B8-497B-B9EC-D79F7197B60E@tu-chemnitz.eu>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <306311DA-E5B8-497B-B9EC-D79F7197B60E@tu-chemnitz.eu>
Subject: Re: [ptxdist] [PATCH] fix typo in bash_completion
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sat, Dec 08, 2012 at 05:35:01PM +0100, Daniel Kriesten wrote:
> This prevents bash_completion from working correctly.
> 
> Signed-off-by: Daniel Kriesten <krid@tu-chemnitz.eu>
> ---
> scripts/bash_completion | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/bash_completion b/scripts/bash_completion
> index ea3921d..719cb35 100644
> --- a/scripts/bash_completion
> +++ b/scripts/bash_completion
> @@ -112,7 +112,7 @@ _ptxdist_completion()
> 		;;
> 	clean)
> 		COMPREPLY=( root )
> -		;&
> +		;;

Why this change? ";&" means fall through, like omitting then 'break' in C
code. This is intentional.

Michael

> 	get|extract|prepare|compile|install|targetinstall|tags)
> 		COMPREPLY+=( $( compgen -W "$( $_ptxdist_cmd print PTX_PACKAGES_SELECTED 2> /dev/null)" -- $cur ) )
> 		;;
> -- 
> 1.8.0
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de