From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] fix typo in bash_completion
Date: Mon, 10 Dec 2012 09:50:47 +0100 [thread overview]
Message-ID: <20121210085047.GJ26985@pengutronix.de> (raw)
In-Reply-To: <306311DA-E5B8-497B-B9EC-D79F7197B60E@tu-chemnitz.eu>
On Sat, Dec 08, 2012 at 05:35:01PM +0100, Daniel Kriesten wrote:
> This prevents bash_completion from working correctly.
>
> Signed-off-by: Daniel Kriesten <krid@tu-chemnitz.eu>
> ---
> scripts/bash_completion | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/bash_completion b/scripts/bash_completion
> index ea3921d..719cb35 100644
> --- a/scripts/bash_completion
> +++ b/scripts/bash_completion
> @@ -112,7 +112,7 @@ _ptxdist_completion()
> ;;
> clean)
> COMPREPLY=( root )
> - ;&
> + ;;
Why this change? ";&" means fall through, like omitting then 'break' in C
code. This is intentional.
Michael
> get|extract|prepare|compile|install|targetinstall|tags)
> COMPREPLY+=( $( compgen -W "$( $_ptxdist_cmd print PTX_PACKAGES_SELECTED 2> /dev/null)" -- $cur ) )
> ;;
> --
> 1.8.0
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-12-10 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 16:35 Daniel Kriesten
2012-12-10 8:50 ` Michael Olbrich [this message]
2012-12-11 15:16 ` Daniel Kriesten
2012-12-13 12:10 ` Daniel Kriesten
2012-12-14 10:18 ` Michael Olbrich
2012-12-14 12:28 ` Daniel Kriesten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210085047.GJ26985@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox