mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] rootfs: change permissions of initial device nodes
Date: Thu, 18 Oct 2012 14:35:03 +0200	[thread overview]
Message-ID: <20121018123503.GF13313@pengutronix.de> (raw)
In-Reply-To: <1350458572-26175-1-git-send-email-post@lespocky.de>

On Wed, Oct 17, 2012 at 09:22:52AM +0200, Alexander Dahl wrote:
> Non priviledged users could not write to /dev/null before. Checked the
> correct permissions by looking at Ubuntu/Debian and LFS. The
> permissions are maybe overwritten by udev, but on targets without udev
> but static dev tree, this would prevent non-root users to access these
> devices.
> 
> Signed-off-by: Alexander Dahl <post@lespocky.de>

Thanks, applied.

Michael

> ---
>  rules/rootfs.make |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 4ba33d1..602391f 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -38,8 +38,8 @@ ifdef PTXCONF_ROOTFS_DEV
>  	@$(call install_copy, rootfs, 0, 0, 0755, /dev)
>  endif
>  ifdef PTXCONF_ROOTFS_DEV_INITIAL
> -	@$(call install_node, rootfs, 0, 0, 0644, c, 1, 3, /dev/null)
> -	@$(call install_node, rootfs, 0, 0, 0644, c, 1, 5, /dev/zero)
> +	@$(call install_node, rootfs, 0, 0, 0666, c, 1, 3, /dev/null)
> +	@$(call install_node, rootfs, 0, 0, 0666, c, 1, 5, /dev/zero)
>  	@$(call install_node, rootfs, 0, 0, 0600, c, 5, 1, /dev/console)
>  endif
>  ifdef PTXCONF_ROOTFS_HOME
> -- 
> 1.7.2.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2012-10-18 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 15:45 [ptxdist] [PATCH] rootfs: change permissions of initial device nodes according to LFS 6.1.1 Alexander Dahl
2012-10-16 16:01 ` Michael Olbrich
2012-10-17  7:22   ` [ptxdist] [PATCH] rootfs: change permissions of initial device nodes Alexander Dahl
2012-10-18 12:35     ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121018123503.GF13313@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox