From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1TLch1-00040w-4u for ptxdist@pengutronix.de; Tue, 09 Oct 2012 18:30:03 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1TLch1-0000fy-3G for ptxdist@pengutronix.de; Tue, 09 Oct 2012 18:30:03 +0200 Date: Tue, 9 Oct 2012 18:30:03 +0200 From: Michael Olbrich Message-ID: <20121009163003.GT19651@pengutronix.de> References: <1349798618-15718-1-git-send-email-post@lespocky.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1349798618-15718-1-git-send-email-post@lespocky.de> Subject: Re: [ptxdist] [PATCH] timezone: introduce option TIMEZONE_INSTALL_LOCALTIME for more flexibility with own rules Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Tue, Oct 09, 2012 at 06:03:38PM +0200, Alexander Dahl wrote: > This patch introduces TIMEZONE_INSTALL_LOCALTIME as variable before > GLIBC_LOCALTIME. You can decide now if you want to install > /etc/localtime and /etc/timezone. I actually used this for a > > "depends on !TIMEZONE_INSTALL_LOCALTIME" > > in one of my own rules which where I can decide if this is stored in > root filesystem or on a separare data partition with symlinks to it. > > Maybe it's handy for the public. keep is simple: rename GLIBC_LOCALTIME -> TIMEZONE_LOCALTIME while at it. and use ifneq ($(call remove_quotes,$(PTXCONF_TIMEZONE_LOCALTIME)),) in targetinstall then you can just use an empty string and depends on GLIBC_LOCALTIME = "" in your rules. Michael > Signed-off-by: Alexander Dahl > --- > rules/timezone.in | 28 ++++++++++++++++++++-------- > 1 files changed, 20 insertions(+), 8 deletions(-) > > diff --git a/rules/timezone.in b/rules/timezone.in > index 09a3d9d..b663d5a 100644 > --- a/rules/timezone.in > +++ b/rules/timezone.in > @@ -15,15 +15,27 @@ if TIMEZONE > > comment "Timezone support" > > -config GLIBC_LOCALTIME > - prompt "Timezone for /etc/localtime and /etc/timezone" > - default "Europe/Berlin" > - string > +menuconfig TIMEZONE_INSTALL_LOCALTIME > + bool > + prompt "Install /etc/localtime and /etc/timezone" > + default y > help > - Where should /etc/localtime point to? (e.g. put in "Europe/Berlin" > - here to let it point to /usr/share/zoneinfo/Europe/Berlin) > - Additionally this value is written to /etc/timezone like on Debian > - or for systemd. > + Optionally install /etc/localtime as symlink to zoneinfo folder > + and /etc/timezone for convenient reading of current setting. This > + determines the system local time. > + > +if TIMEZONE_INSTALL_LOCALTIME > + config GLIBC_LOCALTIME > + prompt "Timezone for /etc/localtime and /etc/timezone" > + default "Europe/Berlin" > + string > + help > + Where should /etc/localtime point to? (e.g. put in > + "Europe/Berlin" here to let it point to > + /usr/share/zoneinfo/Europe/Berlin) > + Additionally this value is written to /etc/timezone like on > + Debian or for systemd. > +endif > > config TIMEZONE_LOCAL_DATABASE > bool > -- > 1.7.2.5 > > > -- > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de