mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCHv2] dosfstools: Fix missing environment forwarding
Date: Fri, 29 Jun 2012 15:24:39 +0200	[thread overview]
Message-ID: <201206291524.39218.jbe@pengutronix.de> (raw)
In-Reply-To: <20120629124149.GS10551@pengutronix.de>

With the current rule file, PTXdist does not forward any of the required
environment variables. Only the DOSFSTOOLS_MAKEVARS settings are used to
build the tools, so at least the correct compiler was used, but not the
correct header and library include paths for example.

Signed-off-by: Juergen Beisert <jbe@pengutronix.de>

diff --git a/rules/dosfstools.make b/rules/dosfstools.make
index 5b9c527..28f8432 100644
--- a/rules/dosfstools.make
+++ b/rules/dosfstools.make
@@ -27,21 +27,28 @@ DOSFSTOOLS_SOURCE	:= $(SRCDIR)/$(DOSFSTOOLS_SRC)
 DOSFSTOOLS_DIR		:= $(BUILDDIR)/$(DOSFSTOOLS)
 
 # ----------------------------------------------------------------------------
-# Prepare
+# Prepare (nothing to be done here)
 # ----------------------------------------------------------------------------
 
-DOSFSTOOLS_PATH	:= PATH=$(CROSS_PATH)
-DOSFSTOOLS_ENV 	:= $(CROSS_ENV)
+DOSFSTOOLS_CONF_TOOL := NO
 
-DOSFSTOOLS_MAKEVARS := \
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
+
+DOSFSTOOLS_MAKE_ENV := $(CROSS_ENV)
+DOSFSTOOLS_MAKE_OPT := \
 	OPTFLAGS='-O2 -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' \
 	PREFIX=/usr \
-	SBINDIR=/sbin \
-	$(CROSS_ENV_CC)
+	SBINDIR=/sbin
 
-$(STATEDIR)/dosfstools.prepare:
-	@$(call targetinfo)
-	@$(call touch)
+# ----------------------------------------------------------------------------
+# Install
+# ----------------------------------------------------------------------------
+
+DOSFSTOOLS_INSTALL_OPT := \
+	$(DOSFSTOOLS_MAKE_OPT) \
+	install
 
 # ----------------------------------------------------------------------------
 # Target-Install

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      parent reply	other threads:[~2012-06-29 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 13:20 [ptxdist] [PATCH] " Juergen Beisert
2012-06-29 12:41 ` Michael Olbrich
2012-06-29 13:04   ` Juergen Beisert
2012-06-29 13:24   ` Juergen Beisert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206291524.39218.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox