* [ptxdist] [PATCH] dosfstools: Fix missing environment forwarding
@ 2012-06-26 13:20 Juergen Beisert
2012-06-29 12:41 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Beisert @ 2012-06-26 13:20 UTC (permalink / raw)
To: ptxdist
With the current rule file, PTXdist does not forward any of the required
environment variables. Only the DOSFSTOOLS_MAKEVARS settings are used to
build the tools, so at least the correct compiler was used, but not the
correct header and library include paths for example.
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
diff --git a/rules/dosfstools.make b/rules/dosfstools.make
index 5b9c527..87f6c20 100644
--- a/rules/dosfstools.make
+++ b/rules/dosfstools.make
@@ -27,21 +27,30 @@ DOSFSTOOLS_SOURCE := $(SRCDIR)/$(DOSFSTOOLS_SRC)
DOSFSTOOLS_DIR := $(BUILDDIR)/$(DOSFSTOOLS)
# ----------------------------------------------------------------------------
-# Prepare
+# Prepare (nothing to be done here)
# ----------------------------------------------------------------------------
-DOSFSTOOLS_PATH := PATH=$(CROSS_PATH)
-DOSFSTOOLS_ENV := $(CROSS_ENV)
+$(STATEDIR)/dosfstools.prepare:
+ @$(call targetinfo)
+ @$(call touch)
+
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
-DOSFSTOOLS_MAKEVARS := \
+DOSFSTOOLS_MAKE_ENV := $(CROSS_ENV)
+DOSFSTOOLS_MAKE_OPT := \
OPTFLAGS='-O2 -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' \
PREFIX=/usr \
- SBINDIR=/sbin \
- $(CROSS_ENV_CC)
+ SBINDIR=/sbin
-$(STATEDIR)/dosfstools.prepare:
- @$(call targetinfo)
- @$(call touch)
+# ----------------------------------------------------------------------------
+# Install
+# ----------------------------------------------------------------------------
+
+DOSFSTOOLS_INSTALL_OPT := \
+ $(DOSFSTOOLS_MAKE_OPT) \
+ install
# ----------------------------------------------------------------------------
# Target-Install
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] dosfstools: Fix missing environment forwarding
2012-06-26 13:20 [ptxdist] [PATCH] dosfstools: Fix missing environment forwarding Juergen Beisert
@ 2012-06-29 12:41 ` Michael Olbrich
2012-06-29 13:04 ` Juergen Beisert
2012-06-29 13:24 ` [ptxdist] [PATCHv2] " Juergen Beisert
0 siblings, 2 replies; 4+ messages in thread
From: Michael Olbrich @ 2012-06-29 12:41 UTC (permalink / raw)
To: ptxdist
On Tue, Jun 26, 2012 at 03:20:47PM +0200, Juergen Beisert wrote:
> With the current rule file, PTXdist does not forward any of the required
> environment variables. Only the DOSFSTOOLS_MAKEVARS settings are used to
> build the tools, so at least the correct compiler was used, but not the
> correct header and library include paths for example.
>
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
>
> diff --git a/rules/dosfstools.make b/rules/dosfstools.make
> index 5b9c527..87f6c20 100644
> --- a/rules/dosfstools.make
> +++ b/rules/dosfstools.make
> @@ -27,21 +27,30 @@ DOSFSTOOLS_SOURCE := $(SRCDIR)/$(DOSFSTOOLS_SRC)
> DOSFSTOOLS_DIR := $(BUILDDIR)/$(DOSFSTOOLS)
>
> # ----------------------------------------------------------------------------
> -# Prepare
> +# Prepare (nothing to be done here)
> # ----------------------------------------------------------------------------
>
> -DOSFSTOOLS_PATH := PATH=$(CROSS_PATH)
> -DOSFSTOOLS_ENV := $(CROSS_ENV)
> +$(STATEDIR)/dosfstools.prepare:
> + @$(call targetinfo)
> + @$(call touch)
DOSFSTOOLS_CONF_TOOL := NO
Michael
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
>
> -DOSFSTOOLS_MAKEVARS := \
> +DOSFSTOOLS_MAKE_ENV := $(CROSS_ENV)
> +DOSFSTOOLS_MAKE_OPT := \
> OPTFLAGS='-O2 -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' \
> PREFIX=/usr \
> - SBINDIR=/sbin \
> - $(CROSS_ENV_CC)
> + SBINDIR=/sbin
>
> -$(STATEDIR)/dosfstools.prepare:
> - @$(call targetinfo)
> - @$(call touch)
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +DOSFSTOOLS_INSTALL_OPT := \
> + $(DOSFSTOOLS_MAKE_OPT) \
> + install
>
> # ----------------------------------------------------------------------------
> # Target-Install
>
> --
> Pengutronix e.K. | Juergen Beisert |
> Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] dosfstools: Fix missing environment forwarding
2012-06-29 12:41 ` Michael Olbrich
@ 2012-06-29 13:04 ` Juergen Beisert
2012-06-29 13:24 ` [ptxdist] [PATCHv2] " Juergen Beisert
1 sibling, 0 replies; 4+ messages in thread
From: Juergen Beisert @ 2012-06-29 13:04 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Olbrich
Michael Olbrich wrote:
> [...]
> > diff --git a/rules/dosfstools.make b/rules/dosfstools.make
> > index 5b9c527..87f6c20 100644
> > --- a/rules/dosfstools.make
> > +++ b/rules/dosfstools.make
> > @@ -27,21 +27,30 @@ DOSFSTOOLS_SOURCE := $(SRCDIR)/$(DOSFSTOOLS_SRC)
> > DOSFSTOOLS_DIR := $(BUILDDIR)/$(DOSFSTOOLS)
> >
> > # ----------------------------------------------------------------------
> > # Prepare
> > +# Prepare (nothing to be done here)
> > # ----------------------------------------------------------------------
> >
> > -DOSFSTOOLS_PATH := PATH=$(CROSS_PATH)
> > -DOSFSTOOLS_ENV := $(CROSS_ENV)
> > +$(STATEDIR)/dosfstools.prepare:
> > + @$(call targetinfo)
> > + @$(call touch)
>
> DOSFSTOOLS_CONF_TOOL := NO
\o/ one more magic macro !
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ptxdist] [PATCHv2] dosfstools: Fix missing environment forwarding
2012-06-29 12:41 ` Michael Olbrich
2012-06-29 13:04 ` Juergen Beisert
@ 2012-06-29 13:24 ` Juergen Beisert
1 sibling, 0 replies; 4+ messages in thread
From: Juergen Beisert @ 2012-06-29 13:24 UTC (permalink / raw)
To: ptxdist
With the current rule file, PTXdist does not forward any of the required
environment variables. Only the DOSFSTOOLS_MAKEVARS settings are used to
build the tools, so at least the correct compiler was used, but not the
correct header and library include paths for example.
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
diff --git a/rules/dosfstools.make b/rules/dosfstools.make
index 5b9c527..28f8432 100644
--- a/rules/dosfstools.make
+++ b/rules/dosfstools.make
@@ -27,21 +27,28 @@ DOSFSTOOLS_SOURCE := $(SRCDIR)/$(DOSFSTOOLS_SRC)
DOSFSTOOLS_DIR := $(BUILDDIR)/$(DOSFSTOOLS)
# ----------------------------------------------------------------------------
-# Prepare
+# Prepare (nothing to be done here)
# ----------------------------------------------------------------------------
-DOSFSTOOLS_PATH := PATH=$(CROSS_PATH)
-DOSFSTOOLS_ENV := $(CROSS_ENV)
+DOSFSTOOLS_CONF_TOOL := NO
-DOSFSTOOLS_MAKEVARS := \
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
+
+DOSFSTOOLS_MAKE_ENV := $(CROSS_ENV)
+DOSFSTOOLS_MAKE_OPT := \
OPTFLAGS='-O2 -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' \
PREFIX=/usr \
- SBINDIR=/sbin \
- $(CROSS_ENV_CC)
+ SBINDIR=/sbin
-$(STATEDIR)/dosfstools.prepare:
- @$(call targetinfo)
- @$(call touch)
+# ----------------------------------------------------------------------------
+# Install
+# ----------------------------------------------------------------------------
+
+DOSFSTOOLS_INSTALL_OPT := \
+ $(DOSFSTOOLS_MAKE_OPT) \
+ install
# ----------------------------------------------------------------------------
# Target-Install
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-29 13:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-26 13:20 [ptxdist] [PATCH] dosfstools: Fix missing environment forwarding Juergen Beisert
2012-06-29 12:41 ` Michael Olbrich
2012-06-29 13:04 ` Juergen Beisert
2012-06-29 13:24 ` [ptxdist] [PATCHv2] " Juergen Beisert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox