From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SkaWD-0004Pz-AZ
	for ptxdist@pengutronix.de; Fri, 29 Jun 2012 14:41:49 +0200
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SkaWD-0002LZ-9K
	for ptxdist@pengutronix.de; Fri, 29 Jun 2012 14:41:49 +0200
Date: Fri, 29 Jun 2012 14:41:49 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120629124149.GS10551@pengutronix.de>
References: <201206261520.48071.jbe@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <201206261520.48071.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] dosfstools: Fix missing environment forwarding
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Jun 26, 2012 at 03:20:47PM +0200, Juergen Beisert wrote:
> With the current rule file, PTXdist does not forward any of the required
> environment variables. Only the DOSFSTOOLS_MAKEVARS settings are used to
> build the tools, so at least the correct compiler was used, but not the
> correct header and library include paths for example.
> 
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> 
> diff --git a/rules/dosfstools.make b/rules/dosfstools.make
> index 5b9c527..87f6c20 100644
> --- a/rules/dosfstools.make
> +++ b/rules/dosfstools.make
> @@ -27,21 +27,30 @@ DOSFSTOOLS_SOURCE	:= $(SRCDIR)/$(DOSFSTOOLS_SRC)
>  DOSFSTOOLS_DIR		:= $(BUILDDIR)/$(DOSFSTOOLS)
>  
>  # ----------------------------------------------------------------------------
> -# Prepare
> +# Prepare (nothing to be done here)
>  # ----------------------------------------------------------------------------
>  
> -DOSFSTOOLS_PATH	:= PATH=$(CROSS_PATH)
> -DOSFSTOOLS_ENV 	:= $(CROSS_ENV)
> +$(STATEDIR)/dosfstools.prepare:
> +	@$(call targetinfo)
> +	@$(call touch)

DOSFSTOOLS_CONF_TOOL := NO

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
>  
> -DOSFSTOOLS_MAKEVARS := \
> +DOSFSTOOLS_MAKE_ENV := $(CROSS_ENV)
> +DOSFSTOOLS_MAKE_OPT := \
>  	OPTFLAGS='-O2 -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' \
>  	PREFIX=/usr \
> -	SBINDIR=/sbin \
> -	$(CROSS_ENV_CC)
> +	SBINDIR=/sbin
>  
> -$(STATEDIR)/dosfstools.prepare:
> -	@$(call targetinfo)
> -	@$(call touch)
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +DOSFSTOOLS_INSTALL_OPT := \
> +	$(DOSFSTOOLS_MAKE_OPT) \
> +	install
>  
>  # ----------------------------------------------------------------------------
>  # Target-Install
> 
> -- 
> Pengutronix e.K.                              | Juergen Beisert             |
> Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de