From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1SbT8O-0001SK-Ir for ptxdist@pengutronix.de; Mon, 04 Jun 2012 10:59:32 +0200 Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1SbT8O-0002Gp-Hz for ptxdist@pengutronix.de; Mon, 04 Jun 2012 10:59:32 +0200 Date: Mon, 4 Jun 2012 10:59:32 +0200 From: Michael Olbrich Message-ID: <20120604085932.GG25924@pengutronix.de> References: <1338478080-9393-1-git-send-email-biessmann@corscience.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1338478080-9393-1-git-send-email-biessmann@corscience.de> Subject: Re: [ptxdist] [PATCH] util-linux: fix hexsyntax.c for some systems Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Thu, May 31, 2012 at 05:28:00PM +0200, Andreas Bie=DFmann wrote: > See patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch f= or > detailed description. This occurs when building host-util-linux-ng on Mac OS, right? Please add a comment for this here. > Signed-off-by: Andreas Bie=DFmann > --- > .../0004-text-utils-hexsyntax.c-use-c.h.patch | 32 ++++++++++++++= ++++++ > patches/util-linux-2.21.2/series | 3 +- > 2 files changed, 34 insertions(+), 1 deletion(-) > create mode 100644 patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c= -use-c.h.patch > = > diff --git a/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.= h.patch b/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.pat= ch > new file mode 100644 > index 0000000..4084af3 > --- /dev/null > +++ b/patches/util-linux-2.21.2/0004-text-utils-hexsyntax.c-use-c.h.patch > @@ -0,0 +1,32 @@ > +From: =3D?UTF-8?q?Andreas=3D20Bie=3DC3=3D9Fmann?=3D > +Date: Tue, 29 May 2012 09:51:24 +0200 > +Subject: [PATCH] text-utils/hexsyntax.c: use c.h > +MIME-Version: 1.0 > +Content-Type: text/plain; charset=3DUTF-8 > +Content-Transfer-Encoding: 8bit > + > +This patch hfixes following error for me: > +---8<--- > +hexsyntax.c: In function 'newsyntax': > +hexsyntax.c:115: error: 'program_invocation_short_name' undeclared (firs= t use in this function) > +hexsyntax.c:115: error: (Each undeclared identifier is reported only once > +hexsyntax.c:115: error: for each function it appears in.) > +--->8--- This can only happen if program_invocation_short_name is not defined by the libc (probably glibc specific). Please add something like that to the comment. Otherwise, the patch might be removed later because it 'works'. Michael > + > +Signed-off-by: Andreas Bie=DFmann > +--- > + text-utils/hexsyntax.c | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/text-utils/hexsyntax.c b/text-utils/hexsyntax.c > +index 5cdd1de..74146c8 100644 > +--- a/text-utils/hexsyntax.c > ++++ b/text-utils/hexsyntax.c > +@@ -45,6 +45,7 @@ > + #include "hexdump.h" > + #include "nls.h" > + #include "strutils.h" > ++#include "c.h" > + = > + off_t skip; /* bytes to skip */ > + = > diff --git a/patches/util-linux-2.21.2/series b/patches/util-linux-2.21.2= /series > index 4f56478..45da749 100644 > --- a/patches/util-linux-2.21.2/series > +++ b/patches/util-linux-2.21.2/series > @@ -3,4 +3,5 @@ > 0001-libmount-add-fallbacks-for-old-systems-without-umoun.patch > 0002-__progname-redefinition-fix.patch > 0003-replace-index-with-strchr.patch > -# 5460ef482e2f1fbfb2002773d7074ab5 - git-ptx-patches magic > +0004-text-utils-hexsyntax.c-use-c.h.patch > +# 96d8b4106ab3633e981114542f3d18da - git-ptx-patches magic > -- = > 1.7.10 > = > = > -- = > ptxdist mailing list > ptxdist@pengutronix.de -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de