From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Sa6nF-00033L-IO
	for ptxdist@pengutronix.de; Thu, 31 May 2012 16:56:05 +0200
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Sa6nF-000474-HO
	for ptxdist@pengutronix.de; Thu, 31 May 2012 16:56:05 +0200
Date: Thu, 31 May 2012 16:56:05 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120531145605.GH10627@pengutronix.de>
References: <1338208981-8681-21-git-send-email-bartvdrmeulen@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1338208981-8681-21-git-send-email-bartvdrmeulen@gmail.com>
Subject: Re: [ptxdist] [PATCH] net-snmp: Make config file optional and add
 initd script
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, May 28, 2012 at 02:42:47PM +0200, Bart vdr. Meulen wrote:
> From: "Bart vdr. Meulen" <bartvdrmeulen@gmail.com>
> 
> Add option to make the installation of the snmpd configuration file optional.

why?

> Add option to install a startup script for snmpd agent in init.d directory
> 
> Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
> ---
>  rules/net-snmp.in   |   12 ++++++++++++
>  rules/net-snmp.make |    8 ++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/rules/net-snmp.in b/rules/net-snmp.in
> index 6205a19..6910f7c 100644
> --- a/rules/net-snmp.in
> +++ b/rules/net-snmp.in
> @@ -20,6 +20,18 @@ config NET_SNMP_AGENT
>  	bool
>  	prompt "agent (snmpd)"
>  
> +if NET_SNMP_AGENT
> +
> +config NET_SNMP_AGENT_CONF
> +	bool
> +	prompt "install config file (/etc/snmp/snmpd.conf)"
> +
> +config NET_SNMP_AGENT_INITD
> +	bool
> +	prompt "install startup script (/etc/init.d/snmpd)"
> +
> +endif
> +
>  config NET_SNMP_APPLICATIONS
>  	bool
>  	prompt "apps (snmpget, ...)"
> diff --git a/rules/net-snmp.make b/rules/net-snmp.make
> index ad2d360..49f8300 100644
> --- a/rules/net-snmp.make
> +++ b/rules/net-snmp.make
> @@ -278,10 +278,18 @@ ifdef PTXCONF_NET_SNMP_AGENT
>  # agent helper libs
>  	@$(call install_lib, net-snmp, 0, 0, 0644, libnetsnmphelpers)
>  
> +ifdef PTXCONF_NET_SNMP_AGENT_CONF
>  # agent configuration
>  	@$(call install_alternative, net-snmp, 0, 0, 0644, /etc/snmp/snmpd.conf)
>  endif
>  
> +ifdef PTXCONF_NET_SNMP_AGENT_INITD
> +# agent startup
> +	@$(call install_alternative, net-snmp, 0, 0, 0755, /etc/init.d/snmpd)

This file is missing.

Michael

> +endif
> +
> +endif
> +
>  ifdef PTXCONF_NET_SNMP_APPLICATIONS
>  # apps libs
>  	@$(call install_lib, net-snmp, 0, 0, 0644, libnetsnmptrapd)
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de