From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SZmEU-0007Pr-Ld
	for ptxdist@pengutronix.de; Wed, 30 May 2012 18:58:50 +0200
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SZmEU-0008O7-KY
	for ptxdist@pengutronix.de; Wed, 30 May 2012 18:58:50 +0200
Date: Wed, 30 May 2012 18:58:50 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120530165850.GI31687@pengutronix.de>
References: <1338208981-8681-17-git-send-email-bartvdrmeulen@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1338208981-8681-17-git-send-email-bartvdrmeulen@gmail.com>
Subject: Re: [ptxdist] [PATCH] gdb: Add option to enable expat and phyton
 support
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, May 28, 2012 at 02:42:43PM +0200, Bart vdr. Meulen wrote:
> From: "Bart vdr. Meulen" <bartvdrmeulen@gmail.com>
> 
> Add options so gdb is be build with expat and python support explicit.
> If not enabled explicit gdb tries to detect whether expat and/or python
> libraries are available which may vary on the order the packages are build
> by ptxdist. Enforcing the build order prevents this.
> 
> Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
> ---
>  rules/gdb.in   |   19 +++++++++++++++++++
>  rules/gdb.make |   13 +++++++++++++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/rules/gdb.in b/rules/gdb.in
> index 65c6fff..127ff39 100644
> --- a/rules/gdb.in
> +++ b/rules/gdb.in
> @@ -7,6 +7,8 @@ menuconfig GDB
>  	select LIBC_DL
>  	select GCCLIBS_GCC_S
>  	select NCURSES
> +	select EXPAT if GDB_ENABLE_EXPAT
> +	select PYTHON if GDB_ENABLE_PYTHON

align the 'if' with <tab>

>  	help
>  	  The GNU Debugger
>  
> @@ -18,6 +20,23 @@ menuconfig GDB
>  
>  if GDB
>  
> +config GDB_ENABLE_EXPAT
> +	prompt "enable expat support"
> +	bool
> +	help
> +	  Expat is used for:
> +	    Remote protocol memory maps
> +	    Target descriptions
> +	    Remote shared library lists
> +	    MS-Windows shared libraries
> +	    Traceframe info
> +
> +config GDB_ENABLE_PYTHON
> +	prompt "enable python support"
> +	bool
> +	help
> +	  You can script gdb using the Python programming language
> +
>  config GDB_SHARED
>  	bool "build shared"
>  	default y
> diff --git a/rules/gdb.make b/rules/gdb.make
> index ecbe020..0741929 100644
> --- a/rules/gdb.make
> +++ b/rules/gdb.make
> @@ -57,6 +57,19 @@ GDB_AUTOCONF := \
>  	--disable-werror \
>  	--without-expat
>  
> +ifdef PTXCONF_GDB_ENABLE_EXPAT
> +GDB_AUTOCONF += --with-expat=yes

use ptx/wwo

> +GDB_AUTOCONF += --with-libexpat_prefix=$(SYSROOT)/usr

--with-libexpat-prefix= I think, and is this really needed? $(SYSROOT)/usr
should be in al relevant paths.

Michael

> +else
> +GDB_AUTOCONF += --with-expat=no
> +endif
> +
> +ifdef PTXCONF_GDB_ENABLE_PYTHON
> +GDB_AUTOCONF += --with-python
> +else
> +GDB_AUTOCONF += --with-python=no
> +endif
> +
>  GDB_BUILD_OOT := YES
>  
>  # ----------------------------------------------------------------------------
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de