[ptxdist] [PATCH] ptxdist: Get rid of toolchain check-error message

[ptxdist] [PATCH] ptxdist: Get rid of toolchain check-error message

[Bart vdr. Meulen]

From: Remy Bohmer <linux@bohmer.net>

If no toolchain info is specified, skip check completely

Ptxdist does a toolchain check, but if all fields are empty we
assume it is an external (not an OSELAS) toolchain.

Signed-off-by: Remy Bohmer <linux@bohmer.net>
---
 bin/ptxdist |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/bin/ptxdist b/bin/ptxdist
index 440a7aa..d9486e4 100755
--- a/bin/ptxdist
+++ b/bin/ptxdist
@@ -1382,6 +1382,14 @@ do_select_toolchain_guess()
 	local target="$(ptxd_get_ptxconf PTXCONF_GNU_TARGET)"
 	local gcc_version="$(ptxd_get_ptxconf PTXCONF_CROSSCHAIN_CHECK)"
 
+	if [ -z "${vendor}" -a \
+	     ! -z "${target}" -a \
+	     -z "${gcc_version}" ]; then
+		ptxd_dialog_msgbox \
+			"info: No toolchain information, assuming external toolchain..."
+		return 1
+	fi
+
 	if [ -z "${vendor}" -o \
 	    -z "${target}" -o \
 	    -z "${gcc_version}" ]; then
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxdist: Get rid of toolchain check-error message

[Michael Olbrich]

On Mon, May 28, 2012 at 02:42:30PM +0200, Bart vdr. Meulen wrote:
> From: Remy Bohmer <linux@bohmer.net>
> 
> If no toolchain info is specified, skip check completely
> 
> Ptxdist does a toolchain check, but if all fields are empty we
> assume it is an external (not an OSELAS) toolchain.
> 
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  bin/ptxdist |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 440a7aa..d9486e4 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1382,6 +1382,14 @@ do_select_toolchain_guess()
>  	local target="$(ptxd_get_ptxconf PTXCONF_GNU_TARGET)"
>  	local gcc_version="$(ptxd_get_ptxconf PTXCONF_CROSSCHAIN_CHECK)"
>  
> +	if [ -z "${vendor}" -a \
> +	     ! -z "${target}" -a \

! -z == -n

> +	     -z "${gcc_version}" ]; then

I'd prefer to actually check the gcc version. Or at least allow for both.

Michael

> +		ptxd_dialog_msgbox \
> +			"info: No toolchain information, assuming external toolchain..."
> +		return 1
> +	fi
> +
>  	if [ -z "${vendor}" -o \
>  	    -z "${target}" -o \
>  	    -z "${gcc_version}" ]; then
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de