From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SZdGN-0007Wy-3D
	for ptxdist@pengutronix.de; Wed, 30 May 2012 09:24:11 +0200
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SZdGN-0007AG-2A
	for ptxdist@pengutronix.de; Wed, 30 May 2012 09:24:11 +0200
Date: Wed, 30 May 2012 09:24:11 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120530072411.GK19394@pengutronix.de>
References: <1338208981-8681-4-git-send-email-bartvdrmeulen@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1338208981-8681-4-git-send-email-bartvdrmeulen@gmail.com>
Subject: Re: [ptxdist] [PATCH] ptxdist: Get rid of toolchain check-error
 message
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, May 28, 2012 at 02:42:30PM +0200, Bart vdr. Meulen wrote:
> From: Remy Bohmer <linux@bohmer.net>
> 
> If no toolchain info is specified, skip check completely
> 
> Ptxdist does a toolchain check, but if all fields are empty we
> assume it is an external (not an OSELAS) toolchain.
> 
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  bin/ptxdist |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index 440a7aa..d9486e4 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -1382,6 +1382,14 @@ do_select_toolchain_guess()
>  	local target="$(ptxd_get_ptxconf PTXCONF_GNU_TARGET)"
>  	local gcc_version="$(ptxd_get_ptxconf PTXCONF_CROSSCHAIN_CHECK)"
>  
> +	if [ -z "${vendor}" -a \
> +	     ! -z "${target}" -a \

! -z == -n

> +	     -z "${gcc_version}" ]; then

I'd prefer to actually check the gcc version. Or at least allow for both.

Michael

> +		ptxd_dialog_msgbox \
> +			"info: No toolchain information, assuming external toolchain..."
> +		return 1
> +	fi
> +
>  	if [ -z "${vendor}" -o \
>  	    -z "${target}" -o \
>  	    -z "${gcc_version}" ]; then
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de