mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] oprofile: Add patch to use busybox icm opcontrol
Date: Wed, 30 May 2012 09:21:45 +0200	[thread overview]
Message-ID: <20120530072145.GJ19394@pengutronix.de> (raw)
In-Reply-To: <1338208981-8681-3-git-send-email-bartvdrmeulen@gmail.com>

On Mon, May 28, 2012 at 02:42:29PM +0200, Bart vdr. Meulen wrote:
> From: "Bart vdr. Meulen" <bartvdrmeulen@gmail.com>
> 
> When using busybox wc the '-m' (count chars) option is not supported,
> use the '-c' (count bytes) option which gives the same count result,
> in this case because non-unicode characters are counted

We already have 0.9.7, which includes this fix.

mol

> Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
> ---
>  .../001-make-opcontrol-busybox-compatible.patch    |   24 ++++++++++++++++++++
>  patches/oprofile-0.9.6/series                      |    1 +
>  2 files changed, 25 insertions(+)
>  create mode 100644 patches/oprofile-0.9.6/001-make-opcontrol-busybox-compatible.patch
>  create mode 100644 patches/oprofile-0.9.6/series
> 
> diff --git a/patches/oprofile-0.9.6/001-make-opcontrol-busybox-compatible.patch b/patches/oprofile-0.9.6/001-make-opcontrol-busybox-compatible.patch
> new file mode 100644
> index 0000000..43f9bd5
> --- /dev/null
> +++ b/patches/oprofile-0.9.6/001-make-opcontrol-busybox-compatible.patch
> @@ -0,0 +1,24 @@
> +Use -c to count characters instead of -m
> +
> +When using busybox wc the '-m' (count chars) option is not supported,
> +use the '-c' (count bytes) option which gives the same count result
> +in this case because the count is done over non-unicode characters.
> +
> +Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
> +---
> + utils/opcontrol |    2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +Index: oprofile-0.9.6/utils/opcontrol
> +===================================================================
> +--- oprofile-0.9.6.orig/utils/opcontrol
> ++++ oprofile-0.9.6/utils/opcontrol
> +@@ -1240,7 +1240,7 @@ check_event_mapping_data()
> + 			fi
> + 		fi
> + 	fi
> +-	len=`echo -n $event_num | wc -m`
> ++	len=`echo -n $event_num | wc -c`
> + 	num_chars_in_grpid=`expr $len - 2`
> + 	GRP_NUM_VAL=`echo | awk '{print substr("'"${event_num}"'",1,"'"${num_chars_in_grpid}"'")}'`
> + 	if [ "$GRP_NUM_CK_VAL" = "" ] ; then
> diff --git a/patches/oprofile-0.9.6/series b/patches/oprofile-0.9.6/series
> new file mode 100644
> index 0000000..1dbb427
> --- /dev/null
> +++ b/patches/oprofile-0.9.6/series
> @@ -0,0 +1 @@
> +001-make-opcontrol-busybox-compatible.patch
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2012-05-30  7:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28 12:42 Bart vdr. Meulen
2012-05-30  7:21 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120530072145.GJ19394@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox