From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SK4Y6-0006Kb-Mi
	for ptxdist@pengutronix.de; Tue, 17 Apr 2012 11:18:10 +0200
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SK4Y6-0002Ct-L5
	for ptxdist@pengutronix.de; Tue, 17 Apr 2012 11:18:10 +0200
Date: Tue, 17 Apr 2012 11:18:10 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120417091810.GE8237@pengutronix.de>
References: <20120402203051.GD28453@pengutronix.de>
	<1333528952-2321-1-git-send-email-bernhard@bwalle.de>
	<20120408081515.GG13585@pengutronix.de>
	<20120408152836.GB13618@regiomontanus.bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20120408152836.GB13618@regiomontanus.bwalle.de>
Subject: Re: [ptxdist] [PATCH v3] rules: Add fbterm
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sun, Apr 08, 2012 at 05:28:36PM +0200, Bernhard Walle wrote:
> Hi,
> 
> * Michael Olbrich <m.olbrich@pengutronix.de> [2012-04-08 10:15]:
> > 
> > This is wrong. Now the whole package is only built on x86
> > 
> > PACKAGES-$(PTXCONF_FBTERM) += fbterm
> 
> Of course, that's right.
> 
> > > +# ----------------------------------------------------------------------------
> > > +# Prepare
> > > +# ----------------------------------------------------------------------------
> > > +
> > 
> > ifndef PTXCONF_ARCH_X86
> > undefine PTXCONF_FBTERM_VESA
> > endif
> 
> That yields me to the question if it wouldn't be better to omit that
> check at all. If we can't get Kconfig right, what gives us the check?
> It disables VESA support even when enabled where it's not available, but
> that's the same as configure does automatically.
> 
> But during testing, I discovered another problem: If the option is
> selected, libx86 is built:
> 
>   PACKAGES-$(PTXCONF_ARCH_X86)-$(PTXCONF_LIBX86)
> 
> doesn't help here because the dependency is resolved by kconfig before
> the makefiles get executed. Do you see a problem to solve that?
> 
> Otherwise I would either just omit that VESA option (I don't need it) or
> leave it to the user to select libx86 when FBTERM_VESA is selected.

I've removed the vesa option and applied it.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de