From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3] rules: Add fbterm
Date: Tue, 17 Apr 2012 11:18:10 +0200 [thread overview]
Message-ID: <20120417091810.GE8237@pengutronix.de> (raw)
In-Reply-To: <20120408152836.GB13618@regiomontanus.bwalle.de>
On Sun, Apr 08, 2012 at 05:28:36PM +0200, Bernhard Walle wrote:
> Hi,
>
> * Michael Olbrich <m.olbrich@pengutronix.de> [2012-04-08 10:15]:
> >
> > This is wrong. Now the whole package is only built on x86
> >
> > PACKAGES-$(PTXCONF_FBTERM) += fbterm
>
> Of course, that's right.
>
> > > +# ----------------------------------------------------------------------------
> > > +# Prepare
> > > +# ----------------------------------------------------------------------------
> > > +
> >
> > ifndef PTXCONF_ARCH_X86
> > undefine PTXCONF_FBTERM_VESA
> > endif
>
> That yields me to the question if it wouldn't be better to omit that
> check at all. If we can't get Kconfig right, what gives us the check?
> It disables VESA support even when enabled where it's not available, but
> that's the same as configure does automatically.
>
> But during testing, I discovered another problem: If the option is
> selected, libx86 is built:
>
> PACKAGES-$(PTXCONF_ARCH_X86)-$(PTXCONF_LIBX86)
>
> doesn't help here because the dependency is resolved by kconfig before
> the makefiles get executed. Do you see a problem to solve that?
>
> Otherwise I would either just omit that VESA option (I don't need it) or
> leave it to the user to select libx86 when FBTERM_VESA is selected.
I've removed the vesa option and applied it.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2012-04-17 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 20:07 [ptxdist] [PATCH] " Bernhard Walle
2012-03-28 9:14 ` Michael Olbrich
2012-03-29 7:36 ` [ptxdist] [PATCH v2] " Bernhard Walle
2012-04-02 20:30 ` Michael Olbrich
2012-04-04 8:42 ` [ptxdist] [PATCH v3] " Bernhard Walle
2012-04-08 8:15 ` Michael Olbrich
2012-04-08 15:28 ` Bernhard Walle
2012-04-17 9:18 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417091810.GE8237@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox