From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] host-localedef: Fix build with LLVM GCC
Date: Tue, 17 Apr 2012 11:17:19 +0200 [thread overview]
Message-ID: <20120417091719.GD8237@pengutronix.de> (raw)
In-Reply-To: <1333895561-91057-1-git-send-email-bernhard@bwalle.de>
On Sun, Apr 08, 2012 at 04:32:41PM +0200, Bernhard Walle wrote:
> See description of the patch that is added in localedef-eglibc-* in
> patches.
Thanks, applied.
Michael
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
> ...eam.h-Force-inlining-of-extern-inline-fun.patch | 38 ++++++++++++++++++++
> patches/localedef-eglibc-2.14.1-r17443-ptx1/series | 4 +++
> 2 files changed, 42 insertions(+)
> create mode 100644 patches/localedef-eglibc-2.14.1-r17443-ptx1/0001-argp-fmtstream.h-Force-inlining-of-extern-inline-fun.patch
> create mode 100644 patches/localedef-eglibc-2.14.1-r17443-ptx1/series
>
> diff --git a/patches/localedef-eglibc-2.14.1-r17443-ptx1/0001-argp-fmtstream.h-Force-inlining-of-extern-inline-fun.patch b/patches/localedef-eglibc-2.14.1-r17443-ptx1/0001-argp-fmtstream.h-Force-inlining-of-extern-inline-fun.patch
> new file mode 100644
> index 0000000..11c9e2c
> --- /dev/null
> +++ b/patches/localedef-eglibc-2.14.1-r17443-ptx1/0001-argp-fmtstream.h-Force-inlining-of-extern-inline-fun.patch
> @@ -0,0 +1,38 @@
> +From e363247cae85b8c43d5d4cc8b0e188ff090942b1 Mon Sep 17 00:00:00 2001
> +From: Bernhard Walle <bernhard@bwalle.de>
> +Date: Sun, 8 Apr 2012 16:25:09 +0200
> +Subject: [PATCH] argp-fmtstream.h: Force inlining of 'extern inline'
> + functions
> +
> +LLVM GCC (at least i686-apple-darwin11-llvm-gcc-4.2) doesn't generate a
> +non-inlined version of argp_fmtstream_putc (even if compiled with -O2),
> +so linking the final program fails:
> +
> +------------------------------------------------------
> +Undefined symbols for architecture x86_64:
> + "_argp_fmtstream_putc", referenced from:
> + _usage_argful_short_opt in argp-help.o
> + _argp_args_usage in argp-help.o
> +ld: symbol(s) not found for architecture x86_64
> +------------------------------------------------------
> +
> +FSF GCC doesn't have the problem, BTW.
> +
> +Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> +---
> + eglibc/argp/argp-fmtstream.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/eglibc/argp/argp-fmtstream.h b/eglibc/argp/argp-fmtstream.h
> +index f94207a..67d1ea2 100644
> +--- a/eglibc/argp/argp-fmtstream.h
> ++++ b/eglibc/argp/argp-fmtstream.h
> +@@ -203,7 +203,7 @@ extern int __argp_fmtstream_ensure (argp_fmtstream_t __fs, size_t __amount);
> + #endif
> +
> + #ifndef ARGP_FS_EI
> +-#define ARGP_FS_EI extern inline
> ++#define ARGP_FS_EI extern inline __attribute__ ((always_inline))
> + #endif
> +
> + ARGP_FS_EI size_t
> diff --git a/patches/localedef-eglibc-2.14.1-r17443-ptx1/series b/patches/localedef-eglibc-2.14.1-r17443-ptx1/series
> new file mode 100644
> index 0000000..59bd8c4
> --- /dev/null
> +++ b/patches/localedef-eglibc-2.14.1-r17443-ptx1/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-argp-fmtstream.h-Force-inlining-of-extern-inline-fun.patch
> +# d34ba91ca41689721674ab991d6febfc - git-ptx-patches magic
> --
> 1.7.9.5
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-04-17 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 15:44 [ptxdist] localedef: Build fixes for Darwin Bernhard Walle
2012-02-12 15:56 ` [ptxdist] [PATCH 1/3] Darwin: Define __nonnull when it's not defined Bernhard Walle
2012-02-12 15:56 ` [ptxdist] [PATCH 2/3] Re-generate configure Bernhard Walle
2012-02-12 15:56 ` [ptxdist] [PATCH 3/3] Fix build without gettext Bernhard Walle
2012-03-24 12:15 ` [ptxdist] localedef: Build fixes for Darwin Michael Olbrich
2012-04-07 18:30 ` Bernhard Walle
2012-04-07 18:32 ` [ptxdist] [PATCH] argp-fmtstream.h: Force inlining of 'extern inline' functions Bernhard Walle
2012-04-08 8:10 ` [ptxdist] localedef: Build fixes for Darwin Michael Olbrich
2012-04-08 14:32 ` [ptxdist] [PATCH] host-localedef: Fix build with LLVM GCC Bernhard Walle
2012-04-17 9:17 ` Michael Olbrich [this message]
2012-04-08 14:42 ` [ptxdist] localedef: Build fixes for Darwin Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417091719.GD8237@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox