Re: [ptxdist] [PATCH 2/2] Allow creation of bootable SD card for OMAP CPUs

[Bernhard Walle <bernhard@bwalle.de>]

Hi,

* Andreas Bießmann <biessmann@corscience.de> [2012-04-10 13:32]:
> 
> can we make the second ext3 filesystem optional?
> Anyway, it could be done in a second step. Would be great to get this
> tool into 2012.05!

I would like to get that mainline first and add additional features, if
needed, later.

> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2012 by the ptxdist project <ptxdist@pengutronix.de>
> 
> your copyright?

Honestly, I don't care. But I changed it now to be consistent.

> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +SEL_ROOTFS-$(PTXCONF_IMAGE_OMAPSD)		+= $(IMAGEDIR)/omap_sd.img
> > +
> > +# preprend the $(IMAGEDIR) if PTXCONF_IMAGE_OMAPSD_ADDITIONAL_BOOT_FILES is not
> > +# empty
> > +ifneq ($(PTXCONF_IMAGE_OMAPSD_ADDITIONAL_BOOT_FILES),"")
> > +PTXCONF_IMAGE_OMAPSD_ADDITIONAL_BOOT_FILES_FULL := \
> > +	$(addprefix $(IMAGEDIR)/, $(PTXCONF_IMAGE_OMAPSD_ADDITIONAL_BOOT_FILES))
> > +endif
> > +
> > +$(IMAGEDIR)/omap_sd.img: $(IMAGEDIR)/root.ext2
> > +	@ln -sf $(IMAGEDIR)/linuximage $(IMAGEDIR)/uImage
> 
> alternatively provide a Kconfig option for renaming $(IMAGEDIR)/linuximage?

I fear that breaks too much. 

> > +	@echo "Creating bootable SD card for OMAP";					\
> > +	PATH=$(PTXCONF_SYSROOT_HOST)/bin:$$PATH $(PTXDIST_TOPDIR)/scripts/genomapsdimg	\
> > +		 -m $(IMAGEDIR)/MLO							\
> > +		 -b $(IMAGEDIR)/u-boot.img						\
> 
> use IMAGE_OMAPSD_BOOTLOADER variable here!

Indeed.

> > +		 -k $(IMAGEDIR)/uImage							\
> > +		 -f $(IMAGEDIR)/root.ext2						\
> > +		 -a "$(PTXCONF_IMAGE_OMAPSD_ADDITIONAL_BOOT_FILES_FULL)"		\
> > +		 -o $@
> 
> cleanup $(IMAGEDIR)/uImage?

Done.

> > index 0000000..9c87e45
> > --- /dev/null
> > +++ b/scripts/genomapsdimg
> > @@ -0,0 +1,160 @@
> > +#!/bin/bash
> 
> copyright?

Added.

> catch possible error (in some tests I didn't had sfdisk in $PATH; took
> some time to find this out ;).

The script was not designed to get executed standalone. But well, I
removed the 'set -e' and added some error messages. Please check.

> > +create_filesystem()
> > +{
> > +	local vatstart=$(parted "${OUTPUT}" unit B print 2>/dev/null|grep "^ 1"|awk '{print $2}')
> > +	local vatsize=$(LANG=C fdisk -l "${OUTPUT}" 2>/dev/null|grep W95 |awk '{print $5}')
> > +
> > +	mkdosfs -F 32 -C "${OUTPUT_FAT}" "${vatsize}" >/dev/null 2>&1
> 
> catch error on tool missing?

It is not missing, it would have no effect because I added 'set -e'. The
script aborts and has no chance to output an error.

But as I mentioned above, I removed 'set -e' and added an error message
here and at some more places.


Regards,
Bernhard


-- 
ptxdist mailing list
ptxdist@pengutronix.de