[ptxdist] [PATCH] rules/kernel: switch to xz compression

[ptxdist] [PATCH] rules/kernel: switch to xz compression

[Andreas Bießmann]

kernel is provided since 2.6.0 with xz compression. The main aim to use xz
compression here is to save significant space for local mirrors.

linux-3.3.tar.bz2 is about 75 MiB
linux-3.3.tar.xz is about 63 MiB
 -> saves about 15 %

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
 rules/kernel.make |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/kernel.make b/rules/kernel.make
index 336b76d..4a45a3f 100644
--- a/rules/kernel.make
+++ b/rules/kernel.make
@@ -31,7 +31,7 @@ endif
 #
 KERNEL			:= linux-$(KERNEL_VERSION)
 KERNEL_MD5		:= $(call remove_quotes,$(PTXCONF_KERNEL_MD5))
-KERNEL_SUFFIX		:= tar.bz2
+KERNEL_SUFFIX		:= tar.xz
 KERNEL_DIR		:= $(KERNEL_BDIR)/$(KERNEL)
 KERNEL_CONFIG		:= $(call remove_quotes, $(PTXDIST_PLATFORMCONFIGDIR)/$(PTXCONF_KERNEL_CONFIG))
 KERNEL_LICENSE		:= GPLv2
-- 
1.7.9.6


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] rules/kernel: switch to xz compression

[Michael Olbrich]

On Fri, Apr 06, 2012 at 12:55:29PM +0200, Andreas Bießmann wrote:
> kernel is provided since 2.6.0 with xz compression. The main aim to use xz
> compression here is to save significant space for local mirrors.
> 
> linux-3.3.tar.bz2 is about 75 MiB
> linux-3.3.tar.xz is about 63 MiB
>  -> saves about 15 %

True, and I like that too. However, if I apply this, all BSPs on ptxdist
master will download a new kernel and complain about a wrong md5sum.
But I guess, people using master should be able to deal with this.

I'll apply it and wait for someone to complain :-)

Michael

> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
>  rules/kernel.make |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 336b76d..4a45a3f 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -31,7 +31,7 @@ endif
>  #
>  KERNEL			:= linux-$(KERNEL_VERSION)
>  KERNEL_MD5		:= $(call remove_quotes,$(PTXCONF_KERNEL_MD5))
> -KERNEL_SUFFIX		:= tar.bz2
> +KERNEL_SUFFIX		:= tar.xz
>  KERNEL_DIR		:= $(KERNEL_BDIR)/$(KERNEL)
>  KERNEL_CONFIG		:= $(call remove_quotes, $(PTXDIST_PLATFORMCONFIGDIR)/$(PTXCONF_KERNEL_CONFIG))
>  KERNEL_LICENSE		:= GPLv2
> -- 
> 1.7.9.6
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] rules/kernel: switch to xz compression

[Andreas Bießmann]

Hi Michael,

On 08.04.12 10:45, Michael Olbrich wrote:
> On Fri, Apr 06, 2012 at 12:55:29PM +0200, Andreas Bießmann wrote:
>> kernel is provided since 2.6.0 with xz compression. The main aim to use xz
>> compression here is to save significant space for local mirrors.
>>
>> linux-3.3.tar.bz2 is about 75 MiB
>> linux-3.3.tar.xz is about 63 MiB
>>  -> saves about 15 %
> 
> True, and I like that too. However, if I apply this, all BSPs on ptxdist
> master will download a new kernel and complain about a wrong md5sum.
> But I guess, people using master should be able to deal with this.

So how about ...

>> index 336b76d..4a45a3f 100644
>> --- a/rules/kernel.make
>> +++ b/rules/kernel.make
>> @@ -31,7 +31,7 @@ endif
>>  #
>>  KERNEL			:= linux-$(KERNEL_VERSION)
>>  KERNEL_MD5		:= $(call remove_quotes,$(PTXCONF_KERNEL_MD5))
>> -KERNEL_SUFFIX		:= tar.bz2

+KERNEL_SUFFIX := tar.$(call ptx/ifdef,
PTXCONF_KERNEL_XZ_COMPRESSION,xz,bz2)

>>  KERNEL_DIR		:= $(KERNEL_BDIR)/$(KERNEL)
>>  KERNEL_CONFIG		:= $(call remove_quotes, $(PTXDIST_PLATFORMCONFIGDIR)/$(PTXCONF_KERNEL_CONFIG))
>>  KERNEL_LICENSE		:= GPLv2

would that be better for existing BDPs?

regards

Andreas Bießmann

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] rules/kernel: switch to xz compression

[Bernhard Walle]

* Andreas Bießmann <andreas@biessmann.de> [2012-04-06 12:55]:
> kernel is provided since 2.6.0 with xz compression. The main aim to use xz
> compression here is to save significant space for local mirrors.
> 
> linux-3.3.tar.bz2 is about 75 MiB
> linux-3.3.tar.xz is about 63 MiB
>  -> saves about 15 %

Which leads me to the question: Shouldn't we require xz in the configure
script of ptxdist and drop host-xz? Currently host-xz is only selected
when KERNEL_XZ is set (which means the kernel compression) but not when
some package is compressed which xz.

Currently that packages are the kernel, strace, networkmanager, systemd and
libkmod.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] rules/kernel: switch to xz compression

[Michael Olbrich]

On Tue, Apr 10, 2012 at 01:12:30PM +0200, Bernhard Walle wrote:
> * Andreas Bießmann <andreas@biessmann.de> [2012-04-06 12:55]:
> > kernel is provided since 2.6.0 with xz compression. The main aim to use xz
> > compression here is to save significant space for local mirrors.
> > 
> > linux-3.3.tar.bz2 is about 75 MiB
> > linux-3.3.tar.xz is about 63 MiB
> >  -> saves about 15 %
> 
> Which leads me to the question: Shouldn't we require xz in the configure
> script of ptxdist and drop host-xz? Currently host-xz is only selected
> when KERNEL_XZ is set (which means the kernel compression) but not when
> some package is compressed which xz.
> 
> Currently that packages are the kernel, strace, networkmanager, systemd and
> libkmod.

I suppose so. I didn't do it at first because no essential packages used it
and I didn't want to force it on everyone, but now with the kernel using xz
this changes.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] rules/kernel: switch to xz compression

[Michael Olbrich]

On Sun, Apr 08, 2012 at 02:51:39PM +0200, Andreas Bießmann wrote:
> On 08.04.12 10:45, Michael Olbrich wrote:
> > On Fri, Apr 06, 2012 at 12:55:29PM +0200, Andreas Bießmann wrote:
> >> kernel is provided since 2.6.0 with xz compression. The main aim to use xz
> >> compression here is to save significant space for local mirrors.
> >>
> >> linux-3.3.tar.bz2 is about 75 MiB
> >> linux-3.3.tar.xz is about 63 MiB
> >>  -> saves about 15 %
> > 
> > True, and I like that too. However, if I apply this, all BSPs on ptxdist
> > master will download a new kernel and complain about a wrong md5sum.
> > But I guess, people using master should be able to deal with this.
> 
> So how about ...
> 
> >> index 336b76d..4a45a3f 100644
> >> --- a/rules/kernel.make
> >> +++ b/rules/kernel.make
> >> @@ -31,7 +31,7 @@ endif
> >>  #
> >>  KERNEL			:= linux-$(KERNEL_VERSION)
> >>  KERNEL_MD5		:= $(call remove_quotes,$(PTXCONF_KERNEL_MD5))
> >> -KERNEL_SUFFIX		:= tar.bz2
> 
> +KERNEL_SUFFIX := tar.$(call ptx/ifdef,
> PTXCONF_KERNEL_XZ_COMPRESSION,xz,bz2)
> 
> >>  KERNEL_DIR		:= $(KERNEL_BDIR)/$(KERNEL)
> >>  KERNEL_CONFIG		:= $(call remove_quotes, $(PTXDIST_PLATFORMCONFIGDIR)/$(PTXCONF_KERNEL_CONFIG))
> >>  KERNEL_LICENSE		:= GPLv2
> 
> would that be better for existing BDPs?

No, unless there is a real problem I prefer a clean break.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de